Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build relies on shrinkwrap, release requires it #4770

Merged
merged 3 commits into from
Aug 27, 2015

Conversation

w33ble
Copy link
Contributor

@w33ble w33ble commented Aug 27, 2015

#4768 brought us npm 3

4239f6c brought back the shrinkwrap file

This closes #4764

  • When running the build, copy the shrinkwrap file into the build, and create it if it doesn't already exist
  • When running the release, fatal if there is no shrinkwrap file, and then run the build (which does the above)

w33ble added 2 commits August 26, 2015 18:41
build will create it if it's missing, copy it to the build and also create a version without dev deps
release requires it and fatals if it doesn't exist

Conflicts:
	tasks/build/index.js
@spalger
Copy link
Contributor

spalger commented Aug 27, 2015

LGTM!

spalger added a commit that referenced this pull request Aug 27, 2015
Build relies on shrinkwrap, release requires it
@spalger spalger merged commit f06d0b2 into elastic:master Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shrinkwrapped modules being skipped?
2 participants