Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrinkwrapped modules being skipped? #4764

Closed
w33ble opened this issue Aug 26, 2015 · 1 comment · Fixed by #4770
Closed

Shrinkwrapped modules being skipped? #4764

w33ble opened this issue Aug 26, 2015 · 1 comment · Fixed by #4770

Comments

@w33ble
Copy link
Contributor

w33ble commented Aug 26, 2015

There seems to be a version discrepancy with the shipped version and the shrinkwrap file in v4.1.1, in particular with Bluebird.

The shrinkwrap file in v4.1.1 specifies Bluebird version v2.9.27, but the version that shipped with the binary we distribute is using v2.9.30.

screenshot 2015-08-26 13 01 57

Either there's an issue with our build process, or 4.1.1 was built without the shrinkwrap file, in which case there's an issue with our workflow and we need more automation.

@spalger
Copy link
Contributor

spalger commented Aug 26, 2015

Yes, we need better process around this. I think that we need to create a grunt task for doing the release commit, and it should probably go something like this:

rm -rf node_modules
npm install
npm shrinkwrap
git add npm-shrinkwrap.json
git commit -m "version $V"
git tag "v$V"
grunt release
git rm npm-shrinkwrap.json
git commit -m "bump to $NextV"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants