Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] fix redirect to maintain search query string #45184

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Sep 9, 2019

Summary

we add a bug where the component Redirect of react-router was not transferring the search query string to the new route. So this PR should fix that.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 v7.4.0 v7.5.0 labels Sep 9, 2019
@XavierM XavierM self-assigned this Sep 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem

@XavierM XavierM added the release_note:skip Skip the PR/issue when compiling release notes label Sep 9, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

<Route
path="/ml-hosts/"
render={({ location: { search = '' } }) => (
<Redirect from="/ml-hosts/" to={`/ml-hosts${search}`} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this for the ml-hosts, it would be a bug there as well.

<Route
path="/ml-network/"
render={({ location: { search = '' } }) => (
<Redirect from="/ml-network/" to={`/ml-network${search}`} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this for the ml-network, it would be a bug there as well.

Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it out, played with it, and this looks like it is working great.

Thank you for adding in the ML side of the house.

@XavierM XavierM merged commit 7fe7b34 into elastic:master Sep 9, 2019
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 10, 2019
…-to-np-ready

* 'master' of github.com:elastic/kibana: (138 commits)
  [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (elastic#44943)
  update close/delete system index modals (elastic#45037)
  TS return type of createIndexPatternSelect (elastic#45107)
  [ML] Fix focus chart updating. (elastic#45146)
  [ML] Data frame transform: Fix progress in wizard create step. (elastic#45116)
  [Graph] Re-enable functional test (elastic#44683)
  [SIEM] unique table id for each top talkers table (elastic#45014)
  [SIEM] ip details heading draggable (elastic#45179)
  [Maps][File upload] Set complete on index pattern creation (elastic#44423)
  [Maps] unmount map embeddable component on destroy (elastic#45183)
  [SIEM] Adds error toasts to MapEmbeddable component (elastic#45088)
  fix redirect to maintain search query string (elastic#45184)
  [APM] One-line trace summary (elastic#44842)
  [Infra UI] Display non-metric details on Node Detail page (elastic#43551)
  [Maps][File upload] Removing bbox from parsed file pending upstream lib fix (elastic#45194)
  [Logs UI] Improve live streaming behavior when scrolling (elastic#44923)
  [APM] Fix indefinite loading state in agent settings for unauthorized user roles (elastic#44970)
  [Reporting] Rewrite addForceNowQuerystring to getFullUrls (elastic#44851)
  [Reporting/ESQueue] Improve logging of doc-update events (elastic#45077)
  [Reporting] Make screenshot capture less noisy by default (elastic#45185)
  ...
XavierM added a commit to XavierM/kibana that referenced this pull request Sep 12, 2019
XavierM added a commit to XavierM/kibana that referenced this pull request Sep 12, 2019
@XavierM XavierM deleted the siem-fix-redirect-with-search branch June 4, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.4.0 v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants