[Graph] Re-enable functional test #44683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
requested review from
kertal and
LeeDr
and removed request for
a team
flash1293
added
release_note:skip
|
Pinging @elastic/kibana-app |
💔 Build Failed |
|
Seems like clicking the edge is not stable yet - I will look into this. |
|
OK, selecting the edge should be stable now - ran it ~20 times locally without failures. |
💔 Build Failed |
💚 Build Succeeded |
kertal
reviewed
Sep 6, 2019
LeeDr
reviewed
Sep 6, 2019
💚 Build Succeeded |
kertal
approved these changes
Sep 9, 2019
💚 Build Succeeded |
LeeDr
approved these changes
Sep 9, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Sep 10, 2019
flash1293
added a commit
that referenced
this pull request
Sep 10, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 10, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: (138 commits) [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (elastic#44943) update close/delete system index modals (elastic#45037) TS return type of createIndexPatternSelect (elastic#45107) [ML] Fix focus chart updating. (elastic#45146) [ML] Data frame transform: Fix progress in wizard create step. (elastic#45116) [Graph] Re-enable functional test (elastic#44683) [SIEM] unique table id for each top talkers table (elastic#45014) [SIEM] ip details heading draggable (elastic#45179) [Maps][File upload] Set complete on index pattern creation (elastic#44423) [Maps] unmount map embeddable component on destroy (elastic#45183) [SIEM] Adds error toasts to MapEmbeddable component (elastic#45088) fix redirect to maintain search query string (elastic#45184) [APM] One-line trace summary (elastic#44842) [Infra UI] Display non-metric details on Node Detail page (elastic#43551) [Maps][File upload] Removing bbox from parsed file pending upstream lib fix (elastic#45194) [Logs UI] Improve live streaming behavior when scrolling (elastic#44923) [APM] Fix indefinite loading state in agent settings for unauthorized user roles (elastic#44970) [Reporting] Rewrite addForceNowQuerystring to getFullUrls (elastic#44851) [Reporting/ESQueue] Improve logging of doc-update events (elastic#45077) [Reporting] Make screenshot capture less noisy by default (elastic#45185) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #44261
Fixes #18084
Re-enables functional tests for Graph. There were some problems outlined in the issue with testing the shown nodes and edges because the layouting algorithm is not deterministic.
This PR tries to work around these issues and resolves breakages to have coverage for the happy path. This is expected to be temporary solution, because the workspace will be refactored soon (see #44225) and I will make sure to make the visualization accessible which will also simplify functional tests.
Changes:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers