-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[alerting] Removed an unnecessary Actions schema configuration #44974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmmorris
added
Feature:Alerting
v7.5.0
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Stack Services
labels
Sep 6, 2019
Pinging @elastic/kibana-stack-services |
💚 Build Succeeded |
bmcconaghy
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
pmuellr
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 6, 2019
…ic#44974) Removed an unnecessary Actions schema configuration
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 6, 2019
…ete-for-distance_feature * 'master' of github.com:elastic/kibana: [SIEM] Fixes escape bug for filterQuery (elastic#43030) Export saved objects based on search criteria (elastic#44723) refactor(webhook-whitelisting): Removed unneeded schema config (elastic#44974) [APM] Make number of x ticks responsive to the plot width (elastic#44870) [ML] Single metric viewer: Fix top nav refresh behaviour. (elastic#44860)
gmmorris
added a commit
that referenced
this pull request
Sep 6, 2019
… (#44999) Removed an unnecessary Actions schema configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported
Feature:Alerting
release_note:skip
Skip the PR/issue when compiling release notes
v7.5.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A minor refactor of the actions whitelisting configuration: Removed an unnecessary Actions schema configuration
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers