Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export saved objects based on search criteria #44723

Merged
merged 3 commits into from
Sep 6, 2019

Conversation

legrego
Copy link
Member

@legrego legrego commented Sep 3, 2019

🚫 Reverted due to issues discovered with paging

👉 Updated PR here: #47223

Summary

Previously, exporting all saved objects from the Saved Objects Management UI did not take the current search criteria into account.

This PR updates the export logic to only export the saved objects that are returned with the current search criteria (optionally including references, of course).

Resolves #27250
Resolves #22590
Resolves #26236

@elasticmachine
Copy link
Contributor

💔 Build Failed

@legrego legrego marked this pull request as ready for review September 4, 2019 11:57
@legrego legrego requested review from mikecote and rudolf September 4, 2019 11:57
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego added the review label Sep 4, 2019
@epixa epixa added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Sep 4, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@rudolf
Copy link
Contributor

rudolf commented Sep 5, 2019

Thanks! will review tomorrow

Copy link
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested on Chrome

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego merged commit e18606c into elastic:master Sep 6, 2019
@legrego legrego deleted the savedObjects/fix-export-all branch September 6, 2019 14:22
legrego added a commit to legrego/kibana that referenced this pull request Sep 6, 2019
* export all saved objects returned from search, not all saved objects that exist

* remove unused mock
legrego added a commit to legrego/kibana that referenced this pull request Sep 6, 2019
* export all saved objects returned from search, not all saved objects that exist

* remove unused mock
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 6, 2019
…ete-for-distance_feature

* 'master' of github.com:elastic/kibana:
  [SIEM] Fixes escape bug for filterQuery  (elastic#43030)
  Export saved objects based on search criteria (elastic#44723)
  refactor(webhook-whitelisting): Removed unneeded schema config (elastic#44974)
  [APM] Make number of x ticks responsive to the plot width (elastic#44870)
  [ML] Single metric viewer: Fix top nav refresh behaviour. (elastic#44860)
legrego added a commit that referenced this pull request Sep 6, 2019
* export all saved objects returned from search, not all saved objects that exist

* remove unused mock
legrego added a commit that referenced this pull request Sep 6, 2019
* export all saved objects returned from search, not all saved objects that exist

* remove unused mock
legrego added a commit that referenced this pull request Sep 6, 2019
* export all saved objects returned from search, not all saved objects that exist

* remove unused mock
legrego added a commit that referenced this pull request Sep 9, 2019
@mikecote
Copy link
Contributor

mikecote commented Sep 9, 2019

Sorry for the delayed feedback. There may be an issue with pagination using this method where only the first page would get exported.

legrego added a commit that referenced this pull request Sep 9, 2019
legrego added a commit that referenced this pull request Sep 9, 2019
@legrego legrego added reverted release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Sep 9, 2019
legrego added a commit that referenced this pull request Sep 9, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes reverted Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.3.2 v7.4.1 v7.5.0 v8.0.0
Projects
None yet
5 participants