[SIEM] Remove deprecation warning from momentJS test #44732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankHassanabad
added
v8.0.0
release_note:skip
|
Pinging @elastic/siem |
andrew-goldstein
approved these changes
Sep 4, 2019
There was a problem hiding this comment.
I first ran node scripts/jest siem locally against master and observed the deprecation warning (specific to the test) in the console output:
PASS legacy/plugins/siem/public/utils/default_date_settings.test.ts
console.warn ../node_modules/moment/moment.js:297
Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which..
Then, after checking out this branch, I ran the same command, and observed that the warning is no longer present.
LGTM
💚 Build Succeeded |
FrankHassanabad
deleted the
remove-moment-deprecation-warning-from-tests
branch
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this pull request
Sep 4, 2019
## Summary Removes a deprecation warning from a unit test when it passed invalid values to momentJS ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [x] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [x] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) - [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this pull request
Sep 4, 2019
## Summary Removes a deprecation warning from a unit test when it passed invalid values to momentJS ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [x] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [x] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) - [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
FrankHassanabad
added a commit
that referenced
this pull request
Sep 4, 2019
## Summary Removes a deprecation warning from a unit test when it passed invalid values to momentJS ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [x] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [x] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) - [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
FrankHassanabad
added a commit
that referenced
this pull request
Sep 4, 2019
## Summary Removes a deprecation warning from a unit test when it passed invalid values to momentJS ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [x] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [x] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) - [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 4, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: (45 commits) Fixing flaky copy-to-space test (elastic#44656) [ML] Enable data visualizer link on job types page for non-time index (elastic#44667) [ML] Adding index pattern title to wizard summary step (elastic#44662) Convert remaining data.indexPatterns items to use TS (elastic#44654) [visualize/_tsvb_time_series] fix flaky test (elastic#44505) [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718) [SIEM] Remove deprecation warning from momentJS test (elastic#44732) [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728) [optimizer] use more precise cache-busting strategy (elastic#44724) [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415) Update sinon related packages (elastic#43952) [SIEM] change flag to drag and drop field (elastic#44705) Update dependency @types/object-hash to ^1.3.0 (elastic#43954) mark eslint config as root (elastic#44699) Adds geo_point to normalizeType helper (elastic#44410) [Uptime]Feature/38542 align uptime help menu with other apps (elastic#44536) Removed unused remove icon component (elastic#44698) Update unit tests to remove warnings from test output. (elastic#41840) Fix rawChecksums in chromium build and rename for clarity (elastic#44665) [Uptime]removed extra slash from integeration urls (elastic#44469) ... # Conflicts: # rfcs/text/0004_application_service_mounting.md
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 4, 2019
…ana into chore/console-to-np-ready * 'chore/console-to-np-ready' of github.com:jloleysens/kibana: (45 commits) Fixing flaky copy-to-space test (elastic#44656) [ML] Enable data visualizer link on job types page for non-time index (elastic#44667) [ML] Adding index pattern title to wizard summary step (elastic#44662) Convert remaining data.indexPatterns items to use TS (elastic#44654) [visualize/_tsvb_time_series] fix flaky test (elastic#44505) [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718) [SIEM] Remove deprecation warning from momentJS test (elastic#44732) [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728) [optimizer] use more precise cache-busting strategy (elastic#44724) [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415) Update sinon related packages (elastic#43952) [SIEM] change flag to drag and drop field (elastic#44705) Update dependency @types/object-hash to ^1.3.0 (elastic#43954) mark eslint config as root (elastic#44699) Adds geo_point to normalizeType helper (elastic#44410) [Uptime]Feature/38542 align uptime help menu with other apps (elastic#44536) Removed unused remove icon component (elastic#44698) Update unit tests to remove warnings from test output. (elastic#41840) Fix rawChecksums in chromium build and rename for clarity (elastic#44665) [Uptime]removed extra slash from integeration urls (elastic#44469) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes a deprecation warning from a unit test when it passed invalid values to momentJS
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers