Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing flaky copy-to-space test #44656

Merged
merged 4 commits into from
Sep 4, 2019
Merged

Fixing flaky copy-to-space test #44656

merged 4 commits into from
Sep 4, 2019

Conversation

legrego
Copy link
Member

@legrego legrego commented Sep 3, 2019

Summary

Resolves #44575

@legrego legrego added WIP Work in progress release_note:skip Skip the PR/issue when compiling release notes labels Sep 3, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@legrego
Copy link
Member Author

legrego commented Sep 3, 2019

^ transient CI error, no related test failures.

@legrego
Copy link
Member Author

legrego commented Sep 3, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Sep 3, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@legrego legrego removed the WIP Work in progress label Sep 3, 2019
@legrego legrego requested review from azasypkin and kobelb September 3, 2019 17:22
@legrego
Copy link
Member Author

legrego commented Sep 3, 2019

https://kibana-ci.elastic.co/job/elastic+kibana+pull-request/797/ shows CI running the test group 40 times to ensure the test is no longer flakey

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

azasypkin
azasypkin approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@legrego legrego merged commit 4f09de7 into elastic:master Sep 4, 2019
@legrego legrego deleted the spaces/fix-flaky-cts-test branch September 4, 2019 11:33
@legrego legrego mentioned this pull request Sep 4, 2019
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 4, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into chore/console…
213bbdc 
…-to-np-ready

* 'master' of github.com:elastic/kibana: (45 commits)
  Fixing flaky copy-to-space test (elastic#44656)
  [ML] Enable data visualizer link on job types page for non-time index (elastic#44667)
  [ML] Adding index pattern title to wizard summary step (elastic#44662)
  Convert remaining data.indexPatterns items to use TS (elastic#44654)
  [visualize/_tsvb_time_series] fix flaky test (elastic#44505)
  [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718)
  [SIEM] Remove deprecation warning from momentJS test (elastic#44732)
  [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728)
  [optimizer] use more precise cache-busting strategy (elastic#44724)
  [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415)
  Update sinon related packages (elastic#43952)
  [SIEM] change flag to drag and drop field (elastic#44705)
  Update dependency @types/object-hash to ^1.3.0 (elastic#43954)
  mark eslint config as root (elastic#44699)
  Adds geo_point to normalizeType helper (elastic#44410)
  [Uptime]Feature/38542  align uptime help menu with other apps (elastic#44536)
  Removed unused remove icon component (elastic#44698)
  Update unit tests to remove warnings from test output. (elastic#41840)
  Fix rawChecksums in chromium build and rename for clarity (elastic#44665)
  [Uptime]removed extra slash from integeration urls (elastic#44469)
  ...

# Conflicts:
#	rfcs/text/0004_application_service_mounting.md
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 4, 2019
@jloleysens
Merge branch 'chore/console-to-np-ready' of github.com:jloleysens/kib…
0a8648b 
…ana into chore/console-to-np-ready

* 'chore/console-to-np-ready' of github.com:jloleysens/kibana: (45 commits)
  Fixing flaky copy-to-space test (elastic#44656)
  [ML] Enable data visualizer link on job types page for non-time index (elastic#44667)
  [ML] Adding index pattern title to wizard summary step (elastic#44662)
  Convert remaining data.indexPatterns items to use TS (elastic#44654)
  [visualize/_tsvb_time_series] fix flaky test (elastic#44505)
  [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718)
  [SIEM] Remove deprecation warning from momentJS test (elastic#44732)
  [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728)
  [optimizer] use more precise cache-busting strategy (elastic#44724)
  [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415)
  Update sinon related packages (elastic#43952)
  [SIEM] change flag to drag and drop field (elastic#44705)
  Update dependency @types/object-hash to ^1.3.0 (elastic#43954)
  mark eslint config as root (elastic#44699)
  Adds geo_point to normalizeType helper (elastic#44410)
  [Uptime]Feature/38542  align uptime help menu with other apps (elastic#44536)
  Removed unused remove icon component (elastic#44698)
  Update unit tests to remove warnings from test output. (elastic#41840)
  Fix rawChecksums in chromium build and rename for clarity (elastic#44665)
  [Uptime]removed extra slash from integeration urls (elastic#44469)
  ...
legrego added a commit that referenced this pull request Sep 4, 2019
@legrego
Fixing flaky copy-to-space test (#44656) (#44761)
5f91888 
* wait for context menu to appear

* run x-pack-ciGroup4 40 times

* actually enable the flaky test...

* Revert "run x-pack-ciGroup4 40 times"

This reverts commit 71ac8e1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

@kobelb kobelb Awaiting requested review from kobelb

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
3 participants
@legrego @elasticmachine @azasypkin