-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve whitespace in discover table cells for added fields #4102
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
646f9e7
Preserve whitespace in discover table cells for added fields
ycombinator 627b94e
Much cleaner CSS selector logic!
ycombinator 318f89a
Using no_white_space utility instead of making cell template single-line
ycombinator d32034c
Moving the usage of noWhiteSpace to a more appropriate place, IMHO
ycombinator 1c43563
Adding class for _source field
ycombinator 46aea33
Extracting conditional logic to make code more readable
ycombinator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 12 additions & 2 deletions
14
src/kibana/components/doc_table/components/table_row/cell.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,13 @@ | ||
<td <%= timefield ? 'class="discover-table-timefield" width="1%"' : '' %>> | ||
<% | ||
var attributes = ''; | ||
if (timefield) { | ||
attributes='class="discover-table-timefield" width="1%"'; | ||
} else if (sourcefield) { | ||
attributes='class="discover-table-sourcefield"'; | ||
} else { | ||
attributes='class="discover-table-datafield"'; | ||
} | ||
%> | ||
<td <%= attributes %>> | ||
<%= formatted %> | ||
</td> | ||
</td> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!