Preserve whitespace in discover table cells for added fields #4102
Conversation
| <td <%= timefield ? 'class="discover-table-timefield" width="1%"' : '' %>><%= formatted %></td> |
There was a problem hiding this comment.
Pretty sure there are other templates that need to have the whitespace stripped from them (like src/kibana/components/doc_table/components/table_row/details.html). Consider using the no_white_space utility to accomplish this rather than turning them all into single-line templates.
|
@spalger I've used the |
| @@ -104,10 +105,10 @@ define(function (require) { | |||
| } | |||
|
|
|||
| $scope.columns.forEach(function (column) { | |||
| newHtmls.push(cellTemplate({ | |||
| newHtmls.push(noWhiteSpace(cellTemplate({ | |||
There was a problem hiding this comment.
You shouldn't need the noWhiteSpace filter here. The cellTemplate was already stripped of whitespace so any that shows up in the results is from the value and should be shown.
There was a problem hiding this comment.
Removing the noWhiteSpace filter here causes this display for the _source column:
Adding the filter back fixes the display:
I too think its odd that I need to apply this filter over here. I'm guessing there's another way to fix the _source display issue (when the filter is removed) but I haven't been able to figure out how.
There was a problem hiding this comment.
I'd say that the _source field shouldn't have significant white-space. It if does then a couple new lines will hide the rest of the fields. What do you think @rashidkpc?
There was a problem hiding this comment.
I think I found a better fix. It still involves using noWhiteSpace in two places but I think its the right way to use it. Please hold while I commit.
| var cellTemplate = _.template(require('text!components/doc_table/components/table_row/cell.html')); | ||
| var truncateByHeightTemplate = _.template(require('text!partials/truncate_by_height.html')); | ||
| var cellTemplate = _.template(noWhiteSpace(require('text!components/doc_table/components/table_row/cell.html'))); | ||
| var truncateByHeightTemplate = _.template(noWhiteSpace(require('text!partials/truncate_by_height.html'))); |
|
LGTM! |
Preserve whitespace in discover table cells for added fields
Fixes #3993.