Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Migrate deprecated date_histogram parameter #39886

Merged
merged 2 commits into from
Jul 8, 2019

Conversation

dgieselaar
Copy link
Member

Closes #39584.

Replaces 'interval' with 'fixed_interval'

Definition of Done for APM UI

  • Flag and create issues of things that are left out
  • Before/after images or gif of UI changes
  • Release labels
  • Designer sign-off for UI related changes
  • PM approval for bigger, user-facing features

@dgieselaar dgieselaar added the release_note:skip Skip the PR/issue when compiling release notes label Jun 28, 2019
@dgieselaar dgieselaar requested a review from a team as a code owner June 28, 2019 10:11
@dgieselaar dgieselaar requested a review from ogupte June 28, 2019 10:11
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@dgieselaar dgieselaar requested a review from sorenlouv July 2, 2019 18:31
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@dgieselaar
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

Closes elastic#39584.

Replaces 'interval' with 'fixed_interval'
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dgieselaar dgieselaar merged commit 2d70c01 into elastic:master Jul 8, 2019
@dgieselaar dgieselaar deleted the migrate-interval branch July 8, 2019 14:52
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Jul 8, 2019
* [APM] Migrate deprecated date_histogram parameter

Closes elastic#39584.

Replaces 'interval' with 'fixed_interval'

* Update snapshot
dgieselaar added a commit that referenced this pull request Jul 8, 2019
* [APM] Migrate deprecated date_histogram parameter

Closes #39584.

Replaces 'interval' with 'fixed_interval'

* Update snapshot
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Jul 9, 2019
Fixes an issue with distribution aggs failing because elastic#39886 inadvertently changed the `interval` key for a histogram agg to `fixed_interval`, which only works on date_histogram aggs.
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Jul 9, 2019
…tic#40598)

Fixes an issue with distribution aggs failing because elastic#39886 inadvertently changed the `interval` key for a histogram agg to `fixed_interval`, which only works on date_histogram aggs.
dgieselaar added a commit that referenced this pull request Jul 9, 2019
Fixes an issue with distribution aggs failing because #39886 inadvertently changed the `interval` key for a histogram agg to `fixed_interval`, which only works on date_histogram aggs.
dgieselaar added a commit that referenced this pull request Jul 9, 2019
Fixes an issue with distribution aggs failing because #39886 inadvertently changed the `interval` key for a histogram agg to `fixed_interval`, which only works on date_histogram aggs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] date_histogram interval field deprecated upgrade to fixed_interval or calendar_interval
3 participants