-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Migrate deprecated date_histogram parameter #39886
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgieselaar
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Jun 28, 2019
💔 Build Failed |
dgieselaar
force-pushed
the
migrate-interval
branch
from
July 1, 2019 12:17
86590bd
to
4b90fe0
Compare
💔 Build Failed |
dgieselaar
force-pushed
the
migrate-interval
branch
from
July 1, 2019 18:19
4b90fe0
to
cced2a1
Compare
💔 Build Failed |
dgieselaar
force-pushed
the
migrate-interval
branch
from
July 1, 2019 19:52
cced2a1
to
14e5b43
Compare
💔 Build Failed |
sorenlouv
approved these changes
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dgieselaar
force-pushed
the
migrate-interval
branch
from
July 5, 2019 12:12
14e5b43
to
4cf0afc
Compare
💔 Build Failed |
dgieselaar
force-pushed
the
migrate-interval
branch
from
July 8, 2019 10:08
4cf0afc
to
31dfe30
Compare
💔 Build Failed |
retest |
💔 Build Failed |
dgieselaar
force-pushed
the
migrate-interval
branch
from
July 8, 2019 12:33
31dfe30
to
f91d65a
Compare
Closes elastic#39584. Replaces 'interval' with 'fixed_interval'
dgieselaar
force-pushed
the
migrate-interval
branch
from
July 8, 2019 12:41
f91d65a
to
be0ace9
Compare
💔 Build Failed |
💚 Build Succeeded |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jul 8, 2019
* [APM] Migrate deprecated date_histogram parameter Closes elastic#39584. Replaces 'interval' with 'fixed_interval' * Update snapshot
dgieselaar
added a commit
that referenced
this pull request
Jul 8, 2019
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jul 9, 2019
Fixes an issue with distribution aggs failing because elastic#39886 inadvertently changed the `interval` key for a histogram agg to `fixed_interval`, which only works on date_histogram aggs.
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jul 9, 2019
…tic#40598) Fixes an issue with distribution aggs failing because elastic#39886 inadvertently changed the `interval` key for a histogram agg to `fixed_interval`, which only works on date_histogram aggs.
dgieselaar
added a commit
that referenced
this pull request
Jul 9, 2019
Fixes an issue with distribution aggs failing because #39886 inadvertently changed the `interval` key for a histogram agg to `fixed_interval`, which only works on date_histogram aggs.
dgieselaar
added a commit
that referenced
this pull request
Jul 9, 2019
Fixes an issue with distribution aggs failing because #39886 inadvertently changed the `interval` key for a histogram agg to `fixed_interval`, which only works on date_histogram aggs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39584.
Replaces 'interval' with 'fixed_interval'
Definition of Done for APM UI
Flag and create issues of things that are left outBefore/after images or gif of UI changesDesigner sign-off for UI related changesPM approval for bigger, user-facing features