Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] date_histogram interval field deprecated upgrade to fixed_interval or calendar_interval #39584

Closed
ogupte opened this issue Jun 25, 2019 · 2 comments · Fixed by #39886
Closed

[APM] date_histogram interval field deprecated upgrade to fixed_interval or calendar_interval #39584

ogupte opened this issue Jun 25, 2019 · 2 comments · Fixed by #39886
Assignees
@dgieselaar
Labels
blocker Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture

Comments

@ogupte
Copy link
Contributor

ogupte commented Jun 25, 2019

APM is added to the TODO list as blocking #27410
We should replace all uses of interval within our date_histogram queries to either fixed_interval or calendar_interval. We currently use some helper function that generate this field based on the calendar selection (especially for charts and metrics), so we'll need to make sure it sets the new field correctly, so we can mark ourselves complete in this overall effort.
@ogupte ogupte added [zube]: Inbox blocker technical debt Improvement of the software architecture and operational architecture labels Jun 25, 2019
@graphaelli graphaelli added [zube]: Planned for release Team:APM All issues that need APM UI Team support and removed [zube]: Inbox labels Jun 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@graphaelli graphaelli removed the :apm label Jun 27, 2019
@dgieselaar
Copy link
Member

From the ES docs:

Calendar-aware intervals are configured with the calendar_interval parameter. Calendar intervals can only be specified in "singular" quantities of the unit (1d, 1M, etc). Multiples, such as 2d, are not supported and will throw an exception.

AFAICT we never force any calculated interval to be 1, and we don't have it hardcoded anywhere either. So changing all instances to fixed_interval is probably the right solution. I'll open up a PR.

@dgieselaar dgieselaar self-assigned this Jun 28, 2019
@dgieselaar dgieselaar mentioned this issue Jun 28, 2019
Merged
5 tasks
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Jul 8, 2019
@dgieselaar
[APM] Migrate deprecated date_histogram parameter
be0ace9 
Closes elastic#39584.

Replaces 'interval' with 'fixed_interval'
dgieselaar added a commit that referenced this issue Jul 8, 2019
@dgieselaar
[APM] Migrate deprecated date_histogram parameter (#39886)
2d70c01 
* [APM] Migrate deprecated date_histogram parameter

Closes #39584.

Replaces 'interval' with 'fixed_interval'

* Update snapshot
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Jul 8, 2019
@dgieselaar
[APM] Migrate deprecated date_histogram parameter (elastic#39886)
d221668 
* [APM] Migrate deprecated date_histogram parameter

Closes elastic#39584.

Replaces 'interval' with 'fixed_interval'

* Update snapshot
dgieselaar added a commit that referenced this issue Jul 8, 2019
@dgieselaar
[APM] Migrate deprecated date_histogram parameter (#39886) (#40521)
306b47c 
* [APM] Migrate deprecated date_histogram parameter

Closes #39584.

Replaces 'interval' with 'fixed_interval'

* Update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
blocker Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Migrate deprecated date_histogram parameter dgieselaar/kibana
5 participants
@graphaelli @sorenlouv @dgieselaar @ogupte @elasticmachine