Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[percy] define snapshot width to match current client width #39631

Merged
merged 1 commit into from
Jun 26, 2019
Merged

[percy] define snapshot width to match current client width #39631

merged 1 commit into from
Jun 26, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jun 25, 2019

Fixes #39628

When capturing a dom snapshot for percy, include the widths option to set the width of the snapshot based on the current document width so that browser.setWindowSize() influences the size of the snapshots rendered by Percy.

@spalger spalger added Team:Operations Team label for Operations Team test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.3.0 labels Jun 25, 2019
@spalger spalger requested review from nreese and liza-mae June 25, 2019 23:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@spalger spalger added the v7.2.1 label Jun 25, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

nreese
nreese approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review

liza-mae
liza-mae approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit ec26ffb into elastic:master Jun 26, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Jun 26, 2019
[percy] define snapshot width to match current client width (elastic#…
4bf730d 
…39631)
@spalger spalger mentioned this pull request Jun 26, 2019
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Jun 26, 2019
[percy] define snapshot width to match current client width (elastic#…
e79292c 
…39631)
@spalger spalger mentioned this pull request Jun 26, 2019
Merged
@spalger
Copy link
Contributor Author

spalger commented Jun 26, 2019 •
edited
Loading

7.x/7.3: ece4709
7.2: af8a93c

@spalger spalger deleted the implement/percy-match-client-width branch June 26, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liza-mae liza-mae liza-mae approved these changes

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team test_ui_functional v7.2.1 v7.3.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add options to FTR for percy
4 participants
@spalger @elasticmachine @nreese @liza-mae