-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to FTR for percy #39628
Comments
Pinging @elastic/kibana-operations |
What kind of options do you have in mind? I think it makes sense to use the |
Width and height |
Do you think it'd be fine if we limited it to one width, since we're capturing the canvas elements as PNG data we would need to resize the browser between multiple snapshot calls to support multiple widths. |
Do you think we should just automatically pass the current width of the browser to percy? cc @nreese |
I think functional tests will want to set browser width. One example, visual regression testing for client view port sizes and testing hand-held devices and laptop size screens to ensure elements flow as expected. |
Yeah, and I think it would only make sense for our current dependency on converting |
We need a way to configure Percy snapshots through FTR. We have two ways some global options and per test. See: https://docs.percy.io/docs/build-your-own-sdk
Relates to: #33817
The text was updated successfully, but these errors were encountered: