Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Table tests #36762

Merged
merged 12 commits into from
May 24, 2019
Merged

[TSVB] Table tests #36762

merged 12 commits into from
May 24, 2019

Conversation

vitalics
Copy link
Contributor

@vitalics vitalics commented May 21, 2019 •
edited
Loading

Summary

add test for changing metrics
This PR without multijobs usage
PR with multijobs: #36762

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@vitalics vitalics requested a review from dmlemeshko May 22, 2019 13:00
@vitalics vitalics marked this pull request as ready for review May 22, 2019 13:00
dmlemeshko
dmlemeshko requested changes May 22, 2019
View reviewed changes
src/functional_test_runner/lib/mocha/setup_mocha.js Outdated
@@ -62,6 +62,7 @@ export async function setupMocha(lifecycle, log, config, providers) {
mocha,
include: config.get('suiteTags.include'),
exclude: config.get('suiteTags.exclude'),

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid changing non-related files

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

dmlemeshko
dmlemeshko approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally for both Chrome & FF on MacOS.

@vitalics vitalics merged commit 2db82c5 into elastic:master May 24, 2019
@vitalics vitalics deleted the TSVB-Table-1 branch May 24, 2019 09:10
This was referenced May 24, 2019
Closed
Merged
vitalics added a commit to vitalics/kibana that referenced this pull request May 24, 2019
@vitalics
[TSVB] Table tests (elastic#36762)
6ef2608 
* implement table tests
vitalics added a commit that referenced this pull request May 24, 2019
@vitalics
[TSVB] Table tests (#36762) (#37071)
04c6505 
* implement table tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitalics @elasticmachine @dmlemeshko