[TSVB] Table: Base refactoring (30 runs) #35162
Closed
+166
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💚 Build Succeeded |
vitalics
changed the title
|
Please run |
dmlemeshko
requested changes
Apr 17, 2019
| public async setFieldForAggregation(field: string, aggNth: number = 0): Promise<void> { | ||
| const labels = await find.allByCssSelector('.tvbSeriesEditor__container .tvbSeriesEditor'); | ||
| const label = labels[aggNth]; | ||
| const fieldEl = (await label.findAllByCssSelector('[data-test-subj = "comboBoxInput"]'))[1]; |
There was a problem hiding this comment.
It does not look like a reliable way. Can we set a unique data-test-subj for a parent element?
There was a problem hiding this comment.
2 fields are the same for the current label
There was a problem hiding this comment.
Waiting for merge pr #35356. After that I will add data-test-subj property for labels
💚 Build Succeeded |
💚 Build Succeeded |
2 tasks
dmlemeshko
requested changes
Apr 24, 2019
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
vitalics
changed the title
|
close issue, since #36762 already merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add test for changing metrics
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers