Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Changes interval to fixed_interval in aggregations in created jobs #36759

Merged
merged 2 commits into from
May 22, 2019
Merged

[ML] Changes interval to fixed_interval in aggregations in created jobs #36759

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a21112
[ML] Changes interval to fixed_interval in aggregations in created jobs
jgowdyelastic May 21, 2019
105d2ea
updates following review
jgowdyelastic May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions x-pack/plugins/ml/public/jobs/new_job/simple/single_metric/create_job/create_job_service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export function SingleMetricJobServiceProvider() {
buckets: {
date_histogram: {
field: formConfig.timeField,
interval: interval
fixed_interval: interval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this include units or just be a bare number? I just realised not specifying any units is also deprecated in 7.2, so if there are currently no units it should append "ms".

Same in the other places in this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 105d2ea

},
aggregations: {
[formConfig.timeField]: {
Expand All @@ -237,7 +237,7 @@ export function SingleMetricJobServiceProvider() {
buckets: {
date_histogram: {
field: formConfig.timeField,
interval: ((interval / 100) * 10) // use 10% of bucketSpan to allow for better sampling
fixed_interval: ((interval / 100) * 10) // use 10% of bucketSpan to allow for better sampling
},
aggregations: {
[dtr.field_name]: {
Expand All @@ -261,7 +261,7 @@ export function SingleMetricJobServiceProvider() {
buckets: {
date_histogram: {
field: formConfig.timeField,
interval: interval
fixed_interval: interval
},
aggregations: {
[formConfig.timeField]: {
Expand Down
2 changes: 1 addition & 1 deletion ...ml/server/models/data_recognizer/modules/apache_ecs/ml/datafeed_low_request_rate_ecs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"buckets": {
"date_histogram": {
"field": "@timestamp",
"interval": 900000,
"fixed_interval": 900000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"15m" would be nicer.

Same in the other 3 modules.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 105d2ea

"offset": 0,
"order": {
"_key": "asc"
Expand Down
2 changes: 1 addition & 1 deletion ...ins/ml/server/models/data_recognizer/modules/apache_ecs/ml/datafeed_visitor_rate_ecs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"buckets": {
"date_histogram": {
"field": "@timestamp",
"interval": 900000,
"fixed_interval": 900000,
"offset": 0,
"order": {
"_key": "asc"
Expand Down
2 changes: 1 addition & 1 deletion .../ml/server/models/data_recognizer/modules/nginx_ecs/ml/datafeed_low_request_rate_ecs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"buckets": {
"date_histogram": {
"field": "@timestamp",
"interval": 900000,
"fixed_interval": 900000,
"offset": 0,
"order": {
"_key": "asc"
Expand Down
2 changes: 1 addition & 1 deletion ...gins/ml/server/models/data_recognizer/modules/nginx_ecs/ml/datafeed_visitor_rate_ecs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"buckets": {
"date_histogram": {
"field": "@timestamp",
"interval": 900000,
"fixed_interval": 900000,
"offset": 0,
"order": {
"_key": "asc"
Expand Down