Skip to content

Commit

Permalink
updates following review
Browse files Browse the repository at this point in the history
  • Loading branch information
jgowdyelastic committed May 21, 2019
1 parent 5a21112 commit 105d2ea
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export function SingleMetricJobServiceProvider() {
buckets: {
date_histogram: {
field: formConfig.timeField,
fixed_interval: interval
fixed_interval: `${interval}ms`
},
aggregations: {
[formConfig.timeField]: {
Expand All @@ -237,7 +237,7 @@ export function SingleMetricJobServiceProvider() {
buckets: {
date_histogram: {
field: formConfig.timeField,
fixed_interval: ((interval / 100) * 10) // use 10% of bucketSpan to allow for better sampling
fixed_interval: `${((interval / 100) * 10)}ms` // use 10% of bucketSpan to allow for better sampling
},
aggregations: {
[dtr.field_name]: {
Expand All @@ -261,7 +261,7 @@ export function SingleMetricJobServiceProvider() {
buckets: {
date_histogram: {
field: formConfig.timeField,
fixed_interval: interval
fixed_interval: `${interval}ms`
},
aggregations: {
[formConfig.timeField]: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"buckets": {
"date_histogram": {
"field": "@timestamp",
"fixed_interval": 900000,
"fixed_interval": "15m",
"offset": 0,
"order": {
"_key": "asc"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"buckets": {
"date_histogram": {
"field": "@timestamp",
"fixed_interval": 900000,
"fixed_interval": "15m",
"offset": 0,
"order": {
"_key": "asc"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"buckets": {
"date_histogram": {
"field": "@timestamp",
"fixed_interval": 900000,
"fixed_interval": "15m",
"offset": 0,
"order": {
"_key": "asc"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"buckets": {
"date_histogram": {
"field": "@timestamp",
"fixed_interval": 900000,
"fixed_interval": "15m",
"offset": 0,
"order": {
"_key": "asc"
Expand Down

0 comments on commit 105d2ea

Please sign in to comment.