-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Check availability of integrated applications #35543
[Uptime] Check availability of integrated applications #35543
Conversation
…egrated with Uptime in the future.
Pinging @elastic/uptime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - My main focus was the capabilities_adapter
, and it's using UI Capabilities in a way that I'd expect. Thanks again for doing this!
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using the feature described. LGTM
jenkins, retest this please |
jenkins test this |
💔 Build Failed |
💔 Build Failed |
jenkins test this |
💚 Build Succeeded |
…egrated with Uptime in the future. (elastic#35543)
Summary
This PR is a response to a comment recommending that we add these checks to help us ensure we aren't linking to features that are not available.
We are planning to integrate with APM, Logs, and Infrastructure UI plugins, so I am attempting to add a check for the availability of those plugins as part of the Uptime UI bootstrapping process. Part of our additions to Uptime will be checking that these apps are available in the current space before displaying links or other integrated data.
Testing this PR
Prerequisite
To make this easy, paste the following code here and save the file:
Instructions
false
for each of the spacestrue
nowChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers