Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Check availability of integrated applications #35543

Merged

Conversation

justinkambic
Copy link
Contributor

@justinkambic justinkambic commented Apr 24, 2019

Summary

This PR is a response to a comment recommending that we add these checks to help us ensure we aren't linking to features that are not available.

We are planning to integrate with APM, Logs, and Infrastructure UI plugins, so I am attempting to add a check for the availability of those plugins as part of the Uptime UI bootstrapping process. Part of our additions to Uptime will be checking that these apps are available in the current space before displaying links or other integrated data.

Testing this PR

Prerequisite

To make this easy, paste the following code here and save the file:

const { isApmAvailable, isInfraAvailable, isLogsAvailable } = props;
console.log(`apm: ${isApmAvailable}`);
console.log(`infra: ${isInfraAvailable}`);
console.log(`logs: ${isLogsAvailable}`);

Instructions

  • Start up this patch
  • Start up Elasticsearch
  • In Management > Spaces: disable Logs, Infrastructure, and APM
    image
  • Load the Uptime app
  • In your browser's console log, you should see false for each of the spaces
  • Reverse what you did before (re-enable the three plugins)
  • Reload Uptime app, those values should be true now

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@justinkambic justinkambic added chore v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.2.0 labels Apr 24, 2019
@justinkambic justinkambic self-assigned this Apr 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - My main focus was the capabilities_adapter, and it's using UI Capabilities in a way that I'd expect. Thanks again for doing this!

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the feature described. LGTM

@andrewvc
Copy link
Contributor

jenkins, retest this please

@justinkambic
Copy link
Contributor Author

jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@justinkambic
Copy link
Contributor Author

jenkins test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic justinkambic merged commit a343899 into elastic:master May 1, 2019
justinkambic added a commit to justinkambic/kibana that referenced this pull request May 1, 2019
justinkambic added a commit that referenced this pull request May 1, 2019
@justinkambic
Copy link
Contributor Author

Backported to:
7.x/7.1.0 083241f
#35868

@justinkambic justinkambic deleted the uptime_integrated-app-availability branch May 1, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants