[Uptime] Uptime to APM integration #34892

justinkambic · 2019-04-10T20:50:52Z

Summary

Add APM integration. The intended result of these changes is to allow users to quickly and efficiently navigate from Uptime to APM, with a pre-filtered list of services based on the domain of a selected service/host they're monitoring in both solutions.

Example: Jennifer is monitoring her company's production site home page and notices several blips in its sparkline on the Uptime monitor list. She clicks the APM integration button and is navigated to the APM app, where she can view internal app performance and determine if there are actionable problems related to the 404s she noticed.

~~WIP.~~

Testing

Prereq's

To test these changes, we will need to do some configuration. The prerequisites to testing this feature is to have:

A running APM server
A service that is transmitting monitoring data to your APM server
A heartbeat instance monitoring your service from step 2.
Configure an APM index pattern

Go to Management -> Index Patterns and configure an apm-* pattern

A few options for configuring APM/your service:

when I'm testing locally I use a node process I've configured to use APM's node agent.
There's also the APM integration testing repo, which you can configure locally.
Eden: you can correspond with the APM team to see if you can use EDEN with a local Kibana instance running these changes.

Testing functionality

After you've configured your APM server/service, configure Heartbeat to monitor the same service. Then load the Uptime UI and attempt to follow the integration link:

APM should be filtered by the same date range as your Uptime page, and the url.domain field should correspond to the domain that Heartbeat has supplied.

Visual review

After conferring with the design team I've decided that it's better to implement these integrations as Actions Column items using the API provided by EuiBasicTable.

~~The primary thing we are adding here is a popover to our Monitors list component.~~

~~We have an icon button to expose the popover:~~

~~Today we are just adding an integration for APM. We will be adding additional integrations to this popover targeting 7.1. The expanded popover looks like:~~

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-04-10T20:50:53Z

Pinging @elastic/uptime

elasticmachine · 2019-04-10T21:33:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-04-12T19:38:12Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-04-16T15:53:25Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-04-17T17:18:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-04-30T16:03:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-04-30T16:49:02Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-04-30T17:41:05Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

x-pack/plugins/uptime/public/components/functional/monitor_list_actions_popover.tsx

andrewvc · 2019-04-30T20:38:04Z

x-pack/plugins/uptime/public/components/functional/monitor_list_actions_popover.tsx

+            }
+          )}
+          color="subdued"
+          iconType="boxesHorizontal"


Maybe there's a better icon option now that we don't show other icons next to this. The boxes make sense as an ellipsis to other icons, but alone they are weird. See the SS below:

There is a popout icon, but that's not really right for a popover:

Maybe we could get some input from @elastic/eui-design or @elastic/kibana-design ?

@andrewvc I am fine with changing the icon. Would you be ok with me making a follow-up issue where we could discuss this in more detail so we don't hold up this PR any longer? There are other PRs downstream of this one that are blocked until some of this code gets merged.

Yes, I'm OK with that

andrewvc · 2019-04-30T21:06:45Z

Code and functionality LGTM (WFG). Two follow-ups:

Update Icon for popover
Integrate with [Uptime] Check availability of integrated applications #35543

If this winds up being merged before those things are done, can you create issues for those two things @justinkambic ?

justinkambic · 2019-04-30T21:13:00Z

jenkins test this

justinkambic · 2019-04-30T21:13:48Z

If this winds up being merged before those things are done, can you create issues for those two things @justinkambic ?

Sure thing. The first one will almost definitely be an issue, the second one won't because I'm not planning to merge this before that PR.

elasticmachine · 2019-04-30T22:07:11Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-05-01T03:55:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Add integrations popover. * Add some more functionality, code is WIP/mocked. * Trying some things WIP. * Import settings values from context. * Remove obsolete comment. * Add links. * Rename component. Clean up placeholder text and add translations. * Minor tweaks. Rename component file. * Fix import for renamed file. * Add domain to api query result fixtures. * Change integration to utilize EuiTable's actions API. * Add translation for new column heading. * Update busted snapshot. * Add snapshot test for new component. * Refactor integration links to dedicated component. * Remove obsolete index export. * Update monitor list test snapshot. * Default monitor list to empty array instead of undefined. * Extract URL construction to helper function. * Make entire link text clickable for APM integration. * Update broken test snapshot. * Fix type and update test snapshot.

justinkambic · 2019-05-06T20:07:19Z

Backported to:
7.x/7.2.0 55cd59b
#35870

justinkambic added WIP Work in progress enhancement New value added to drive a business result v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.2.0 labels Apr 10, 2019

justinkambic force-pushed the uptime_apm-integration branch from 5e5c4bc to b9c94ac Compare April 12, 2019 19:01

justinkambic added 7 commits April 16, 2019 10:12

Add integrations popover.

31d8f20

Add some more functionality, code is WIP/mocked.

e8a553f

Trying some things WIP.

2d395d9

Import settings values from context.

b910922

Remove obsolete comment.

1b9c131

Add links.

022a958

Rename component. Clean up placeholder text and add translations.

0e34a0f

justinkambic force-pushed the uptime_apm-integration branch from b9c94ac to 0e34a0f Compare April 16, 2019 14:16

Minor tweaks. Rename component file.

6052c4c

justinkambic added review and removed enhancement New value added to drive a business result WIP Work in progress labels Apr 16, 2019

justinkambic marked this pull request as ready for review April 16, 2019 14:42

Fix import for renamed file.

1e0169f

justinkambic self-assigned this Apr 17, 2019

justinkambic requested a review from dov0211 April 17, 2019 15:29

Add domain to api query result fixtures.

fd467fb

justinkambic added 2 commits April 17, 2019 14:42

Change integration to utilize EuiTable's actions API.

8b36951

Add translation for new column heading.

561dc9b

justinkambic added 4 commits April 30, 2019 11:19

Merge branch 'master' into uptime_apm-integration

23c3f42

Refactor integration links to dedicated component.

1d82335

Remove obsolete index export.

42395e6

Update monitor list test snapshot.

4da7738

Default monitor list to empty array instead of undefined.

81d0013

andrewvc reviewed Apr 30, 2019

View reviewed changes

x-pack/plugins/uptime/public/components/functional/monitor_list_actions_popover.tsx Show resolved Hide resolved

justinkambic added 2 commits April 30, 2019 14:22

Extract URL construction to helper function.

e041de6

Make entire link text clickable for APM integration.

169a347

andrewvc reviewed Apr 30, 2019

View reviewed changes

andrewvc approved these changes Apr 30, 2019

View reviewed changes

justinkambic mentioned this pull request Apr 30, 2019

[Uptime] Uptime to Infra integration #35847

Merged

justinkambic added 2 commits April 30, 2019 18:50

Update broken test snapshot.

36d5fe7

Fix type and update test snapshot.

9e74cdd

justinkambic merged commit 5fdb23c into elastic:master May 1, 2019

This was referenced May 1, 2019

[Uptime] Backport (#34892) #35870

Merged

[Discuss] What icon should we use for our integrations popover elastic/uptime#32

Closed

justinkambic deleted the uptime_apm-integration branch May 6, 2019 20:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Uptime to APM integration #34892

[Uptime] Uptime to APM integration #34892

justinkambic commented Apr 10, 2019 •

edited

Loading

elasticmachine commented Apr 10, 2019

elasticmachine commented Apr 10, 2019

elasticmachine commented Apr 12, 2019

elasticmachine commented Apr 16, 2019

elasticmachine commented Apr 17, 2019

elasticmachine commented Apr 30, 2019

elasticmachine commented Apr 30, 2019

elasticmachine commented Apr 30, 2019

andrewvc Apr 30, 2019

justinkambic Apr 30, 2019

andrewvc Apr 30, 2019

andrewvc commented Apr 30, 2019

justinkambic commented Apr 30, 2019

justinkambic commented Apr 30, 2019

elasticmachine commented Apr 30, 2019

elasticmachine commented May 1, 2019

justinkambic commented May 6, 2019

[Uptime] Uptime to APM integration #34892

[Uptime] Uptime to APM integration #34892

Conversation

justinkambic commented Apr 10, 2019 • edited Loading

Summary

Testing

Prereq's

Testing functionality

Visual review

Checklist

For maintainers

elasticmachine commented Apr 10, 2019

elasticmachine commented Apr 10, 2019

💔 Build Failed

elasticmachine commented Apr 12, 2019

💔 Build Failed

elasticmachine commented Apr 16, 2019

💔 Build Failed

elasticmachine commented Apr 17, 2019

💚 Build Succeeded

elasticmachine commented Apr 30, 2019

💔 Build Failed

elasticmachine commented Apr 30, 2019

💔 Build Failed

elasticmachine commented Apr 30, 2019

💔 Build Failed

andrewvc Apr 30, 2019

Choose a reason for hiding this comment

justinkambic Apr 30, 2019

Choose a reason for hiding this comment

andrewvc Apr 30, 2019

Choose a reason for hiding this comment

andrewvc commented Apr 30, 2019

justinkambic commented Apr 30, 2019

justinkambic commented Apr 30, 2019

elasticmachine commented Apr 30, 2019

💔 Build Failed

elasticmachine commented May 1, 2019

💚 Build Succeeded

justinkambic commented May 6, 2019

justinkambic commented Apr 10, 2019 •

edited

Loading