Allow any type of saved object to import / export #34896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
release_note:enhancement
Team:Core
|
Pinging @elastic/kibana-platform |
mikecote
commented
Apr 10, 2019
src/legacy/core_plugins/kibana/server/routes/api/management/saved_objects/find.js
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/server/routes/api/management/saved_objects/relationships.js
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/public/management/sections/objects/_objects.js
Outdated
Show resolved
Hide resolved
...nagement/sections/objects/components/objects_table/components/relationships/relationships.js
Show resolved
Hide resolved
...nagement/sections/objects/components/objects_table/components/relationships/relationships.js
Show resolved
Hide resolved
..._plugins/kibana/public/management/sections/objects/components/objects_table/objects_table.js
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mikecote
commented
Apr 11, 2019
...kibana/public/management/sections/objects/components/objects_table/components/table/table.js
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kobelb
approved these changes
May 6, 2019
cqliu1
approved these changes
May 6, 2019
💚 Build Succeeded |
|
woooo great work @mikecote!! Really excited to see this PR in merged 👍 🍾 |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
May 6, 2019
* Modify the relationships API and UI * Remove type validation on export * Update relationship test snapshots * Change relationships table titles * Change relationships UI to share one table * Add server side logic to inject meta data into saved objects from plugins * Manually enable each type of saved object to support * Use injected vars to determine what types are import / exportable * Fix some broken tests * Remove unused translations * Fix relationships mocha tests * Remove tests that ensured types are restricted, functionality removed * Move kfetch logic into separate file * Add inAppUrl to missing types * Add tooltip to management table titles that aren't links * Make relationships screen support filtering by type * Fix failing tests * Add refresh support for inAppUrls * Add error notifications when export API call fails * Add relationship direction * Fix broken tests * Remove graph workspace from import / export * Use parent / child terminology for relationships * Use direct relationship terminology * Flip view / edit logic in saved object management app * Make config saved object redirect to advanced settings * Fix broken tests * Remove unused translations * Code cleanup * Add tests * Add fallback overwrite confirmation object title * Enforce supported types on import, export and resolve import errors * Fix broken tests * Fix broken tests pt2 * Fix broken tests pt3 * Test cleanup * Use server.decorate to access savedobjectschemas * Fix some broken tests * Fix broken tests, add new title to relationships screen * Fix some broken tests * Handle dynamic versions * Fix inAppUrl structure in tests * Re-use generic canGoInApp * Fix broken tests * Apply maps PR feedback * Apply PR feedback pt1 * Apply PR feedback pt2 * Add savedObjectsManagement to uiExports * Fix broken tests * Fix encodeURIComponent implementation * Merge 403 and unsupported type errors into single error * Apply suggestion * Remove import / exportable by default, opt-in instead * Fix type config to show up properly in the table * Change config type title and fix tests * Remove isImportableAndExportable where set to false (new default) * Remove comments referencing to authorization * Add unit tests for spaces * Add unit tests for security plugin * Change can* signature to be the same as their equivalent function, apply PR feedback * Cleanup git diff * Revert "Change can* signature to be the same as their equivalent function, apply PR feedback" This reverts commit b657ac8. * Revert "Add unit tests for security plugin" This reverts commit 6287a8c. * Revert "Add unit tests for spaces" This reverts commit 2674a9d. * Revert "Remove comments referencing to authorization" This reverts commit 9618c2c. * Revert "Merge 403 and unsupported type errors into single error" This reverts commit 99aea10. * Add CUSTOM_ELEMENT_TYPE for import / export * Fix broken tests * Fix broken tests pt2 * Prevent crashing app when inAppUrl is undefined
mikecote
added a commit
that referenced
this pull request
May 7, 2019
* Modify the relationships API and UI * Remove type validation on export * Update relationship test snapshots * Change relationships table titles * Change relationships UI to share one table * Add server side logic to inject meta data into saved objects from plugins * Manually enable each type of saved object to support * Use injected vars to determine what types are import / exportable * Fix some broken tests * Remove unused translations * Fix relationships mocha tests * Remove tests that ensured types are restricted, functionality removed * Move kfetch logic into separate file * Add inAppUrl to missing types * Add tooltip to management table titles that aren't links * Make relationships screen support filtering by type * Fix failing tests * Add refresh support for inAppUrls * Add error notifications when export API call fails * Add relationship direction * Fix broken tests * Remove graph workspace from import / export * Use parent / child terminology for relationships * Use direct relationship terminology * Flip view / edit logic in saved object management app * Make config saved object redirect to advanced settings * Fix broken tests * Remove unused translations * Code cleanup * Add tests * Add fallback overwrite confirmation object title * Enforce supported types on import, export and resolve import errors * Fix broken tests * Fix broken tests pt2 * Fix broken tests pt3 * Test cleanup * Use server.decorate to access savedobjectschemas * Fix some broken tests * Fix broken tests, add new title to relationships screen * Fix some broken tests * Handle dynamic versions * Fix inAppUrl structure in tests * Re-use generic canGoInApp * Fix broken tests * Apply maps PR feedback * Apply PR feedback pt1 * Apply PR feedback pt2 * Add savedObjectsManagement to uiExports * Fix broken tests * Fix encodeURIComponent implementation * Merge 403 and unsupported type errors into single error * Apply suggestion * Remove import / exportable by default, opt-in instead * Fix type config to show up properly in the table * Change config type title and fix tests * Remove isImportableAndExportable where set to false (new default) * Remove comments referencing to authorization * Add unit tests for spaces * Add unit tests for security plugin * Change can* signature to be the same as their equivalent function, apply PR feedback * Cleanup git diff * Revert "Change can* signature to be the same as their equivalent function, apply PR feedback" This reverts commit b657ac8. * Revert "Add unit tests for security plugin" This reverts commit 6287a8c. * Revert "Add unit tests for spaces" This reverts commit 2674a9d. * Revert "Remove comments referencing to authorization" This reverts commit 9618c2c. * Revert "Merge 403 and unsupported type errors into single error" This reverts commit 99aea10. * Add CUSTOM_ELEMENT_TYPE for import / export * Fix broken tests * Fix broken tests pt2 * Prevent crashing app when inAppUrl is undefined
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the saved object management UI is capable of working with any type of saved object. By default some features (edit saved object, view saved object, title) will be limited until the type has extra configuration done within
uiExports.savedObjectSchemas[type]. Each saved object needs to be configured to be import and exportable. The configuration is done viauiExports.savedObjectSchemas[type].isImportableAndExportable = true.Fixes #34862.
Fixes #23165.
Fixes #34709.
Fixes #28037.
Fixes #27203.
Fixes #4265.