[Saved Objects] Help text should reference saved search instead of visualizations

[alexfrancoeur]

In this example, we're showing the appropriate warning

Flight logs is a saved search, I wouldn't expect the text to reference visualizations.

I could see this being fixed in one of two ways. Making the first warning more generic to include generically say saved objects. We'll be continuing to add more that can be embedded into a dashboard, Maps maps being one example. The other is to make each help text reference the particular saved object. This could get repetitive quick.

cc: @mikecote

[elasticmachine]

Pinging @elastic/kibana-platform

[mikecote]

I will be working on it this week, feel free to ping me if you want to strategize on changes. I am thinking the generic path and maybe allow customizability as an option (if we want to keep the warnings that exist already).

[alexfrancoeur]

+1, I think that'd be the best approach. Happy to review any changes to wording, @gchaps might be able to provide some valuable feedback as well

…

On Mon, Apr 8, 2019 at 9:03 AM Mike Côté ***@***.***> wrote: I will be working on it this week, feel free to ping me if you want to strategize on changes. I am thinking the generic path and maybe allow customizability as an option (if we want to keep the warnings that exist already). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#34709 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYA-fy2S3CXQ4sgRB0QeHSRwEW47Qluwks5vez4qgaJpZM4ciFfo> .

[mikecote]

I'm thinking we can do something like below where we have 1 table with the objects the current one depends on and another table where it's objects depending on the current one.

One confusion is the export has an "Include dependencies" or "Include related objects" option that is recursive but this one isn't. By recursive I mean a dashboard would include visualization and visualization's index patterns.

[alexfrancoeur]

Thanks Mike! My first thought goes back to a single table, similar to the saved object management table itself. Where we can filter by types if needed but in general, all saved objects are kind of mushed together. The multiple tables confused me a bit at first when I opened up the slider. If we take a step back and look at the dependencies, this is what I see. Let me know if I'm missing anything.

• Dashboard ▶️ Saved Search ▶️ Index Pattern
• Dashboard ▶️ Visualization ▶️ Index Pattern(s)
• Saved Search ▶️ Index Pattern
• Visualization ▶️ Index Pattern(s)
• Maps ▶️ Index Pattern(s)
• No dependencies
  • Canvas Workpad
  • Index Patterns
• Future
  • Dashboard ▶️ Maps ▶️ Index Pattern(s)
  • Alert configuration ▶️ Action ▶️ Secret
  • Report configuration ▶️ Dashboard ▶️ (dependencies listed above)
  • Action ▶️ Secret
  • Secrets - no dependencies?

Nothing really goes too deep. To me, I think it's perfectly acceptable to place all dependencies in the same table. I think we can change the wording on the warning itself to be more generic. Users are already in a saved object management UI, so generally, we can assume they know what a saved object is. What do you think of this error?

Object Type

Here are some saved objects used in this [object type]. You can safely delete this [object type] and its related saved objects will still work properly.

I went with related because I believe this is the relationship view. As far as text goes though, we can probably leverage @gchaps to make it perfect 😄

[gchaps]

@alexfrancoeur How about this:

Here are the saved objects that this [object type] uses. You can safely delete this [object type] without affecting its saved objects.

Is it ok to day "the saved objects" instead of "some of the same objects"?

[mikecote]

@alexfrancoeur I spoke with the design team and they suggested a single table containing relationships in both directions with the ability to filter on type. Right now the screenshot below doesn't indicate what direction the relationship is in but the design team said we can add a column to indicate that. Thoughts?

The screenshot below is what I have working at this moment. It's showing relationships for a saved search where the saved search depends on an index pattern and is used by a dashboard.