[Infra UI] Fixes #34606 - Adjust CSS to fix scrolling bug in Waffle Map #34881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
review
[zube]: In Review
Feature:Metrics UI
|
Pinging @elastic/infrastructure-ui |
simianhacker
changed the title
💚 Build Succeeded |
2 tasks
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Apr 25, 2019
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Apr 25, 2019
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Apr 25, 2019
💚 Build Succeeded |
simianhacker
added a commit
that referenced
this pull request
Apr 25, 2019
simianhacker
added a commit
that referenced
this pull request
Apr 29, 2019
simianhacker
added a commit
that referenced
this pull request
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #34606 by adjusting the CSS on the custom flex components for the waffle map. This also lowers the scrolling section so we the controls are not lost.
Before
After
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately