[Maps] properly wait for map pan and zoom in functional tests #33993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
v8.0.0
v7.2.0
release_note:skip
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
dmlemeshko
approved these changes
Apr 1, 2019
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Apr 1, 2019
…c#33993) * [Maps] properly wait for map pan and zoom in functional tests * unskip tests from merge with master * do not check original view with setView * update expect statements for numbers instead of strings
This was referenced Apr 1, 2019
nreese
added a commit
that referenced
this pull request
Apr 1, 2019
#34277) * [Maps] properly wait for map pan and zoom in functional tests * unskip tests from merge with master * do not check original view with setView * update expect statements for numbers instead of strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33313 introduced changes that broke the maps functional tests using the method
gis_page.clickFitToBounds. The problem was that with a shorterwaitForDeletedtimeout, the map did not have time to pan and zoom to the location calculated from fit to bounds.The tests were skipped in #33977 to unblock the build.
This PR fixes the problem and turns on the skipped tests