FTR: fix 10 sec timeout in waitForDeleted #33313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
changed the title
💔 Build FailedX-Pack Functional Tests.x-pack/test/functional/apps/maps/es_search_source·js.maps app elasticsearch document layer query bar should apply query to fit to bounds setting implicitWait to 0 might be not the best approach, I will investigate |
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build FailedThe only failure: xpack-ciGroup3 passed 20x times 💪 |
This reverts commit 55482de.
💚 Build Succeeded |
LeeDr
approved these changes
Mar 26, 2019
There was a problem hiding this comment.
LGTM - I only code reviewed and checked Jenkins results. The test I initially saw the problem is was
kibana/test/functional/apps/context/_filters.js (in ciGroup1)
We can see from the screenshots below that this PR saves almost 1 minute off that test.
Closes: 33168
Other PR which doesn't have this fix;
This PR with the fix;
|
Closes: #33168 |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Mar 26, 2019
* use css selector instead of className, set implicit wait to 0 * set implicitWait to 2 sec * set default implicitWait to WAIT_FOR_EXISTS_TIME * set timeout to 1 sec, retry for query bar test * sleep 5 sec waiting zoom is finished * sleep is the only way to wait * run x-pack-ciGroup3 20x times * Revert "run x-pack-ciGroup3 20x times" This reverts commit 55482de.
dmlemeshko
added a commit
that referenced
this pull request
Mar 27, 2019
* use css selector instead of className, set implicit wait to 0 * set implicitWait to 2 sec * set default implicitWait to WAIT_FOR_EXISTS_TIME * set timeout to 1 sec, retry for query bar test * sleep 5 sec waiting zoom is finished * sleep is the only way to wait * run x-pack-ciGroup3 20x times * Revert "run x-pack-ciGroup3 20x times" This reverts commit 55482de.
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Mar 27, 2019
* use css selector instead of className, set implicit wait to 0 * set implicitWait to 2 sec * set default implicitWait to WAIT_FOR_EXISTS_TIME * set timeout to 1 sec, retry for query bar test * sleep 5 sec waiting zoom is finished * sleep is the only way to wait * run x-pack-ciGroup3 20x times * Revert "run x-pack-ciGroup3 20x times" This reverts commit 55482de.
dmlemeshko
added a commit
that referenced
this pull request
Mar 27, 2019
💚 Build Succeeded |
joelgriffith
pushed a commit
that referenced
this pull request
Mar 27, 2019
* use css selector instead of className, set implicit wait to 0 * set implicitWait to 2 sec * set default implicitWait to WAIT_FOR_EXISTS_TIME * set timeout to 1 sec, retry for query bar test * sleep 5 sec waiting zoom is finished * sleep is the only way to wait * run x-pack-ciGroup3 20x times * Revert "run x-pack-ciGroup3 20x times" This reverts commit 55482de.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@LeeDr reported a bug with FTR waiting for the element to be removed out of DOM always takes 10 sec.
Why it happened:
waitForDeletedByCssSelectorrelies ondriver.findElements, which usesimplicitWaittimeout for element to be found: by default timeout=timeouts.find(10 sec), sodriver.findElementstries to find element up to 10 sec.Fix: implicit wait is reset to 1000 (1 sec) on start to rely only on explicitTImeout so that
findElementsstops execution on the first attempt and returns the result if elements not found.Since we no longer use Leadfoot, I fixed the following mismatch:
find service has
waitForDeletedByCssSelectorweb_element_wrapper has
waitForDeletedByClassNameChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately