Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes datepicker in ie11 #33325

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Fixes datepicker in ie11 #33325

merged 2 commits into from
Mar 15, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Mar 15, 2019

Summary

Fixes #33300

Some specificity changes changed somewhere since the last fix. !important to the rescue.

image

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@snide snide requested a review from cchaos March 15, 2019 15:53
@snide snide requested a review from a team as a code owner March 15, 2019 15:53
@snide snide requested a review from markov00 March 15, 2019 15:56
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have you found the root cause of this?

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Mar 15, 2019

jenkins test this

@snide
Copy link
Contributor Author

snide commented Mar 15, 2019

LGTM, have you found the root cause of this?

IE11 has trouble with nested flex boxes. You often have to fiddle with the flex basis and grow properties. We fixed this earlier, but likely a new level of specificity was added since that change that trumped the media query. The !important will help trump anything that gets added.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@snide snide merged commit da98757 into elastic:master Mar 15, 2019
@snide snide deleted the ie11/datepciker_fix branch March 15, 2019 18:54
snide added a commit to snide/kibana that referenced this pull request Mar 15, 2019
snide added a commit to snide/kibana that referenced this pull request Mar 15, 2019
snide added a commit that referenced this pull request Mar 15, 2019
snide added a commit that referenced this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No timepicker in Dashboard on IE11
4 participants