-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore dashboard \ visualization lists "sorting while searching" behavior #32583
Conversation
Pinging @elastic/kibana-app |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing which is a bit off is that if the list is loaded the first time, its seems to be not sorted and the first click to the title header doesn't do anything - ideally it would show as sorted ascending and reset to 'unsorted' as soon as the user starts entering a query. But IMHO that isn't too bad, so LGTM 👍
@flash1293 Thanks! I agree with you, but there was a long discussion here and on the kibana design slack channel, about the fact that sorting should reflect user actions, and that if the table appears sorted, it shouldn't be "unsorted" by search. We'll see where it goes :) |
Pinging @elastic/eui-design (EUI) |
Summary
PR resolves the sorting issues mentioned in #31599
The behavior it restores is -
This was done by actually removing initial sorting state from table (because the table state should represent user actions), and sorting the items before passing them down to InMemoryTable in case the query is empty.
P.S. once Kibana uses EUI 9.0.1, users will also be able to unsort a sorted column.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)