Preserve elasticsearch order #1674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 5, 2019 18:35
lizozom
changed the title
|
Is the underlying issue here that unsorting the table does not return it to the original data order? |
|
@chandlerprall The underlaying issue is that searching a sorted table does not show the correct order returned by ES. This is all relevant only for InMemoryTable of course. |
chandlerprall
suggested changes
Mar 5, 2019
| if (!shouldClear) { | ||
| // don't change sorting | ||
| return {}; | ||
| } else if (isQueryEmpty && sorting) { |
There was a problem hiding this comment.
sorting is an object and will always be truthy here
|
Brought up this PR for discussion in slack with @elastic/kibana-design. We've concluded that not clearing the table's sort when the query changes more often matches a user's expectations and follows similar table implementations. |
This was referenced Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we've added the ability to unsort a talbe, we need to be able to use InMemoryTable to show search results in the order defined by ElasticSearch.
To achieve that, I added the preserveSearchResultOrder flag, which in conjunction with allowNeutralSort, will clear existing sorting upon search.
If initial sorting is provided, it's restored when the query is cleared.
Checklist
[ ] Jest tests were updated or added to match the most common scenarios~~ [ ] This required updates to Framer X components~~