[7.0] [ML] Adds missing error handling to annotations request. (#32384) #32489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-ui |
💔 Build Failed |
|
retest |
💔 Build Failed |
💔 Build Failed |
walterra
force-pushed
the
backport/7.0/pr-32384
branch
from
87045ed to
bc2b186
Compare
💔 Build Failed |
💔 Build Failed |
walterra
force-pushed
the
backport/7.0/pr-32384
branch
from
3d51d4e to
77ea70e
Compare
💔 Build Failed |
walterra
force-pushed
the
backport/7.0/pr-32384
branch
from
77ea70e to
8fccb03
Compare
💔 Build Failed |
walterra
force-pushed
the
backport/7.0/pr-32384
branch
from
8fccb03 to
e3e5ca0
Compare
💔 Build Failed |
- This adds more thorough error handling to retrieving annotations from the server to avoid breaking Anomaly Explorer when there's a problem retrieving annotations. The UI will silently fail and hide the annotations table if for whatever reasons annotations cannot be retrieved for the selected jobs (this could be permissions or setup related if e.g. the annotations feature index/aliases are not present). This is now the same behavior like in Single Metric Viewer. The browser console will still output an error message. This fixes an error scenario where Anomaly Explorer would fail to load if a user upgraded to 6.6 because the backend task wasn't run yet to create the annotation index/aliases. - Disables annotations feature in Single Metric Viewer if annotations fail to load. - Use componentDidUpdate and an update check instead of deprecated componentWillUpdate for updating the annotations table in jobs management.
walterra
force-pushed
the
backport/7.0/pr-32384
branch
from
e3e5ca0 to
20b7083
Compare
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.0: