[ML] Adds missing error handling to annotations request. #32384

walterra · 2019-03-04T09:01:30Z

Summary

This adds more thorough error handling to retrieving annotations from the server to avoid breaking Anomaly Explorer when there's a problem retrieving annotations. The UI will silently fail and hide the annotations table if for whatever reasons annotations cannot be retrieved for the selected jobs (this could be permissions or setup related if e.g. the annotations feature index/aliases are not present). This is now the same behavior like in Single Metric Viewer. The browser console will still output an error message. This fixes an error scenario where Anomaly Explorer would fail to load if a user upgraded to 6.6 because the backend task wasn't run yet to create the annotation index/aliases.
Disables annotations feature in Single Metric Viewer if annotations fail to load. 3b0b058
Use componentDidUpdate and an update check instead of deprecated componentWillUpdate for updating the annotations table in jobs management. c1f06a6

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~This was checked for cross-browser compatibility, including a check against IE11~~
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios~~
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This includes a feature addition or change that requires a release note and was labeled appropriately

…xplorer.

elasticmachine · 2019-03-04T09:01:32Z

Pinging @elastic/ml-ui

jgowdyelastic

LGTM

x-pack/plugins/ml/public/explorer/explorer_utils.js

peteharverson

LGTM

elasticmachine · 2019-03-04T10:12:04Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

… componentWillUpdate.

jgowdyelastic · 2019-03-04T15:02:52Z

Latest changes LGTM

peteharverson

Latest commits LGTM

alvarezmelissa87

LGTM ⚡️

elasticmachine · 2019-03-04T15:37:43Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-04T17:14:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-05T14:40:05Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-05T15:24:20Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

- This adds more thorough error handling to retrieving annotations from the server to avoid breaking Anomaly Explorer when there's a problem retrieving annotations. The UI will silently fail and hide the annotations table if for whatever reasons annotations cannot be retrieved for the selected jobs (this could be permissions or setup related if e.g. the annotations feature index/aliases are not present). This is now the same behavior like in Single Metric Viewer. The browser console will still output an error message. This fixes an error scenario where Anomaly Explorer would fail to load if a user upgraded to 6.6 because the backend task wasn't run yet to create the annotation index/aliases. - Disables annotations feature in Single Metric Viewer if annotations fail to load. - Use componentDidUpdate and an update check instead of deprecated componentWillUpdate for updating the annotations table in jobs management.

…2487) - This adds more thorough error handling to retrieving annotations from the server to avoid breaking Anomaly Explorer when there's a problem retrieving annotations. The UI will silently fail and hide the annotations table if for whatever reasons annotations cannot be retrieved for the selected jobs (this could be permissions or setup related if e.g. the annotations feature index/aliases are not present). This is now the same behavior like in Single Metric Viewer. The browser console will still output an error message. This fixes an error scenario where Anomaly Explorer would fail to load if a user upgraded to 6.6 because the backend task wasn't run yet to create the annotation index/aliases. - Disables annotations feature in Single Metric Viewer if annotations fail to load. - Use componentDidUpdate and an update check instead of deprecated componentWillUpdate for updating the annotations table in jobs management.

…2490) - This adds more thorough error handling to retrieving annotations from the server to avoid breaking Anomaly Explorer when there's a problem retrieving annotations. The UI will silently fail and hide the annotations table if for whatever reasons annotations cannot be retrieved for the selected jobs (this could be permissions or setup related if e.g. the annotations feature index/aliases are not present). This is now the same behavior like in Single Metric Viewer. The browser console will still output an error message. This fixes an error scenario where Anomaly Explorer would fail to load if a user upgraded to 6.6 because the backend task wasn't run yet to create the annotation index/aliases. - Disables annotations feature in Single Metric Viewer if annotations fail to load. - Use componentDidUpdate and an update check instead of deprecated componentWillUpdate for updating the annotations table in jobs management.

… (#32494) - This adds more thorough error handling to retrieving annotations from the server to avoid breaking Anomaly Explorer when there's a problem retrieving annotations. The UI will silently fail and hide the annotations table if for whatever reasons annotations cannot be retrieved for the selected jobs (this could be permissions or setup related if e.g. the annotations feature index/aliases are not present). This is now the same behavior like in Single Metric Viewer. The browser console will still output an error message. This fixes an error scenario where Anomaly Explorer would fail to load if a user upgraded to 6.6 because the backend task wasn't run yet to create the annotation index/aliases. - Disables annotations feature in Single Metric Viewer if annotations fail to load. - Use componentDidUpdate and an update check instead of deprecated componentWillUpdate for updating the annotations table in jobs management.

- This adds more thorough error handling to retrieving annotations from the server to avoid breaking Anomaly Explorer when there's a problem retrieving annotations. The UI will silently fail and hide the annotations table if for whatever reasons annotations cannot be retrieved for the selected jobs (this could be permissions or setup related if e.g. the annotations feature index/aliases are not present). This is now the same behavior like in Single Metric Viewer. The browser console will still output an error message. This fixes an error scenario where Anomaly Explorer would fail to load if a user upgraded to 6.6 because the backend task wasn't run yet to create the annotation index/aliases. - Disables annotations feature in Single Metric Viewer if annotations fail to load. - Use componentDidUpdate and an update check instead of deprecated componentWillUpdate for updating the annotations table in jobs management.

… (#32489) - This adds more thorough error handling to retrieving annotations from the server to avoid breaking Anomaly Explorer when there's a problem retrieving annotations. The UI will silently fail and hide the annotations table if for whatever reasons annotations cannot be retrieved for the selected jobs (this could be permissions or setup related if e.g. the annotations feature index/aliases are not present). This is now the same behavior like in Single Metric Viewer. The browser console will still output an error message. This fixes an error scenario where Anomaly Explorer would fail to load if a user upgraded to 6.6 because the backend task wasn't run yet to create the annotation index/aliases. - Disables annotations feature in Single Metric Viewer if annotations fail to load. - Use componentDidUpdate and an update check instead of deprecated componentWillUpdate for updating the annotations table in jobs management.

[ML] Adds missing error handling to annotations request for Anomaly E…

7400222

…xplorer.

walterra added bug Fixes for quality problems that affect the customer experience release_note:fix v7.0.0 :ml Feature:ml-results legacy - do not use v8.0.0 v6.7.0 v7.2.0 v6.6.2 labels Mar 4, 2019

walterra self-assigned this Mar 4, 2019

walterra requested a review from alvarezmelissa87 March 4, 2019 09:01

walterra requested review from peteharverson and jgowdyelastic March 4, 2019 09:01

walterra requested a review from a team as a code owner March 4, 2019 09:01

jgowdyelastic approved these changes Mar 4, 2019

View reviewed changes

x-pack/plugins/ml/public/explorer/explorer_utils.js Show resolved Hide resolved

[ML] Removes now unnecessary async.

d178eb3

peteharverson approved these changes Mar 4, 2019

View reviewed changes

walterra added 2 commits March 4, 2019 15:18

[ML] Disables annotations feature in TSV if annotations fail to load.

3b0b058

[ML] Use componentDidUpdate and an update check instead of deprecated…

c1f06a6

… componentWillUpdate.

walterra changed the title ~~[ML] Adds missing error handling to annotations request for Anomaly Explorer.~~ [ML] Adds missing error handling to annotations request. Mar 4, 2019

peteharverson approved these changes Mar 4, 2019

View reviewed changes

alvarezmelissa87 approved these changes Mar 4, 2019

View reviewed changes

walterra mentioned this pull request Mar 4, 2019

[ML] Annotations #25856

Open

88 tasks

[ML] Fixes if statement to properly check if jobs are set.

726b15a

[ML] watch annotationsEnabled to properly disable brush on update.

5c54b04

[ML] Fix hide annotations brush if annotations checkbox is unchecked.

6a91f52

walterra merged commit 46f7a35 into elastic:master Mar 5, 2019

walterra deleted the ml-fix-annotations-anomaly-explorer-error-handling branch March 5, 2019 16:04

walterra mentioned this pull request Mar 5, 2019

[7.x] [ML] Adds missing error handling to annotations request. (#32384) #32487

Merged

walterra mentioned this pull request Mar 5, 2019

[7.0] [ML] Adds missing error handling to annotations request. (#32384) #32489

Merged

walterra mentioned this pull request Mar 5, 2019

[6.7] [ML] Adds missing error handling to annotations request. (#32384) #32490

Merged

walterra mentioned this pull request Mar 5, 2019

[6.6] [ML] Adds missing error handling to annotations request. (#32384) #32494

Merged

sophiec20 added the Feature:Anomaly Detection ML anomaly detection label Jun 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Adds missing error handling to annotations request. #32384

[ML] Adds missing error handling to annotations request. #32384

walterra commented Mar 4, 2019 •

edited

Loading

elasticmachine commented Mar 4, 2019

jgowdyelastic left a comment

peteharverson left a comment

elasticmachine commented Mar 4, 2019

jgowdyelastic commented Mar 4, 2019

peteharverson left a comment

alvarezmelissa87 left a comment

elasticmachine commented Mar 4, 2019

elasticmachine commented Mar 4, 2019

elasticmachine commented Mar 5, 2019

elasticmachine commented Mar 5, 2019

[ML] Adds missing error handling to annotations request. #32384

[ML] Adds missing error handling to annotations request. #32384

Conversation

walterra commented Mar 4, 2019 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Mar 4, 2019

jgowdyelastic left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

elasticmachine commented Mar 4, 2019

💚 Build Succeeded

jgowdyelastic commented Mar 4, 2019

peteharverson left a comment

Choose a reason for hiding this comment

alvarezmelissa87 left a comment

Choose a reason for hiding this comment

elasticmachine commented Mar 4, 2019

💚 Build Succeeded

elasticmachine commented Mar 4, 2019

💚 Build Succeeded

elasticmachine commented Mar 5, 2019

💚 Build Succeeded

elasticmachine commented Mar 5, 2019

💚 Build Succeeded

walterra commented Mar 4, 2019 •

edited

Loading