[7.x] Typescript dashboard stuff (#27167) #32483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* gridData id changed to i * to.equal panel_state.ts * clarifying return values in panel_utils *fixed imports in dpc consitency across id -> i for gridData, improvment made in dashboard_panel.tsx changed DashboardPanelUiProps onPanelFocused and onPanelBlurred (panel: PanelState) to (panel: string) resolved Problems in TS * Resolved ts testing type errors with DashboardPanelUiProps in dashboard_panel.tsx Updated snapshot for dashboard_panel.test.tsx * Code review from Emma with changes partial PanelState and defining size_x and size_y to numbers adding comment to clarify panel.panelIndex.toString() * test commit to take in Emmas feedback and show the panel_utils and types.ts modified to show panelIndex string | number reverting panel_utils and types.ts changes with panelIndex, keeping other changes from Emmas suggestions * Fixed panel_utils and panel_utils test to create updatedPanel object instead of mutation Revert mutation in panel utils removed ts-ignore statements in __tests__/panel_state.ts
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: