-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* gridData id changed to i * to.equal panel_state.ts * clarifying return values in panel_utils *fixed imports in dpc consitency across id -> i for gridData, improvment made in dashboard_panel.tsx changed DashboardPanelUiProps onPanelFocused and onPanelBlurred (panel: PanelState) to (panel: string) resolved Problems in TS * Resolved ts testing type errors with DashboardPanelUiProps in dashboard_panel.tsx Updated snapshot for dashboard_panel.test.tsx * Code review from Emma with changes partial PanelState and defining size_x and size_y to numbers adding comment to clarify panel.panelIndex.toString() * test commit to take in Emmas feedback and show the panel_utils and types.ts modified to show panelIndex string | number reverting panel_utils and types.ts changes with panelIndex, keeping other changes from Emmas suggestions * Fixed panel_utils and panel_utils test to create updatedPanel object instead of mutation Revert mutation in panel utils removed ts-ignore statements in __tests__/panel_state.ts
- Loading branch information
Showing
11 changed files
with
322 additions
and
195 deletions.
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.