Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing issue with request body not being sent for console DELETE requests #32407

Merged
merged 2 commits into from
Mar 4, 2019
Merged

fixing issue with request body not being sent for console DELETE requests #32407

merged 2 commits into from
Mar 4, 2019

Conversation

bmcconaghy
Copy link
Contributor

@bmcconaghy bmcconaghy commented Mar 4, 2019 •
edited by cjcenizal
Loading

closes #13245

Release note

This PR fixes a bug in Console in which requests which involved the DELETE method and request bodies would fail, e.g. DELETE /_search/scroll { ... }.

Technical details

For some reason Wreck does not read from the stream in the payload when the HTTP verb is DELETE, so this PR adds a call to read to force this if the HTTP verb is DELETE for console requests.

Related to this Node issue: nodejs/node#19179 (comment)

@bmcconaghy bmcconaghy added Feature:Console Dev Tools Console Feature v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.2.0 labels Mar 4, 2019
@bmcconaghy bmcconaghy requested a review from spalger March 4, 2019 17:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@bmcconaghy bmcconaghy force-pushed the fix_DELETE_with_body_in_console branch from 22ff3b3 to 78f887f Compare March 4, 2019 19:24
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

spalger
spalger approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@bmcconaghy bmcconaghy merged commit b355dbe into elastic:master Mar 4, 2019
@bmcconaghy bmcconaghy mentioned this pull request Mar 4, 2019
Merged
@bmcconaghy bmcconaghy deleted the fix_DELETE_with_body_in_console branch March 4, 2019 22:29
bmcconaghy added a commit to bmcconaghy/kibana that referenced this pull request Mar 4, 2019
@bmcconaghy
fixing issue with request body not being sent for console DELETE requ… (
7adf58b 
elastic#32407)

* fix for delete not sending body from console

* better fix that accounts for delays in incoming data
bmcconaghy added a commit that referenced this pull request Mar 4, 2019
@bmcconaghy
fixing issue with request body not being sent for console DELETE requ… (
a4df0b1 
#32407) (#32429)

* fix for delete not sending body from console

* better fix that accounts for delays in incoming data
This was referenced Mar 7, 2019
Merged
Merged
@cjcenizal cjcenizal changed the title fixing issue with request body not being sent for console DELETE requ… fixing issue with request body not being sent for console DELETE requests May 7, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal cjcenizal mentioned this pull request May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
Feature:Console Dev Tools Console Feature release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to clear search scroll via Kibana DevTools
4 participants
@bmcconaghy @elasticmachine @spalger @cjcenizal