-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Corrected API path for invalidate token and SSL certificate examples #39530
Conversation
Pinging @elastic/es-security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions
-------------------------------------------------- | ||
// TESTRESPONSE[s/dGhpcyBpcyBub3QgYSByZWFsIHRva2VuIGJ1dCBpdCBpcyBvbmx5IHRlc3QgZGF0YS4gZG8gbm90IHRyeSB0byByZWFkIHRva2VuIQ==/$body.access_token/] | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
This access token can now be immediately invalidated, as shown in the following example:
Co-Authored-By: lcawl <[email protected]>
Co-Authored-By: lcawl <[email protected]>
Co-Authored-By: lcawl <[email protected]>
Co-Authored-By: lcawl <[email protected]>
Co-Authored-By: lcawl <[email protected]>
The DELETE examples in the invalidate token API reference don't work in the Kibana Console. They return:
This is related to elastic/kibana#13245 Thus I've marked those examples as //KIBANA to only show the "Copy as curl" link. |
Re-enabling //CONSOLE testing now that elastic/kibana#32407 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to #39517
This PR corrects some out-dated examples in the invalidate token API and the SSL certificate API.
It also wraps some long lines of text.
Ideally we can enable the tests on these APIs so that we catch changes like this.