Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Corrected API path for invalidate token and SSL certificate examples #39530

Merged
merged 17 commits into from
Mar 12, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 28, 2019

Related to #39517

This PR corrects some out-dated examples in the invalidate token API and the SSL certificate API.
It also wraps some long lines of text.

Ideally we can enable the tests on these APIs so that we catch changes like this.

@lcawl lcawl added >docs General docs changes v7.0.0 :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v6.7.0 v8.0.0 v7.2.0 labels Feb 28, 2019
@lcawl lcawl requested a review from jkakavas February 28, 2019 18:25
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@lcawl lcawl added the WIP label Feb 28, 2019
@lcawl lcawl removed the WIP label Feb 28, 2019
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions

--------------------------------------------------
// TESTRESPONSE[s/dGhpcyBpcyBub3QgYSByZWFsIHRva2VuIGJ1dCBpdCBpcyBvbmx5IHRlc3QgZGF0YS4gZG8gbm90IHRyeSB0byByZWFkIHRva2VuIQ==/$body.access_token/]


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

This access token can now be immediately invalidated, as shown in the following example:

@lcawl
Copy link
Contributor Author

lcawl commented Mar 1, 2019

The DELETE examples in the invalidate token API reference don't work in the Kibana Console. They return:

{
"error": {
"root_cause": [
{
"type": "parse_exception",
"reason": "request body is required"
}
],
"type": "parse_exception",
"reason": "request body is required"
},
"status": 400
}

This is related to elastic/kibana#13245

Thus I've marked those examples as //KIBANA to only show the "Copy as curl" link.

@lcawl
Copy link
Contributor Author

lcawl commented Mar 7, 2019

Re-enabling //CONSOLE testing now that elastic/kibana#32407 is merged.

@jkakavas jkakavas self-requested a review March 8, 2019 20:20
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit bec0a19 into elastic:master Mar 12, 2019
@lcawl lcawl deleted the xpack-cleanup branch March 12, 2019 20:25
lcawl added a commit to lcawl/elasticsearch that referenced this pull request Mar 12, 2019
@lcawl lcawl removed the v6.7.0 label Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v7.0.0-rc2 v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants