Back button navigation fix 31238

[lizozom]

Summary

Fixed issue 31238, where back navigation would get stuck due to bad URL encoding.

Includes a functional test that was used to reproduce the issue.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11 <--- IE not working at the moment
  Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support]
  Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
  This was checked for keyboard-only and screenreader accessibility

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

Pinging @elastic/kibana-platform

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[spalger]

LGTM!

[sorenlouv]

Hey @lizozom,

Nice work fixing the back button 👍
Unfortunately this also introduced a little side-effect which is affecting all urls in Kibana.

Previously the following query:

?rangeFrom=15%3A55&path=a/b/c

Would be converted by Kibana/Angular to:

?rangeFrom=15:55&path=a%2Fb%2Fc

Note how the rangeFrom value was decoded, and path value was encoded. Super bizarre behaviour already, so really don't blame you. Touching url handling in Kibana is a minefield! 💣

However, after this PR was merged, the same query:

?rangeFrom=15%3A55&path=a/b/c

Is now converted into

?rangeFrom=15:55&path=a%2Fb%2Fc#%2Fhome%3FrangeFrom=15:55&path=a%252Fb%252Fc

[jasonrhodes]

I made an issue for this here: #32721

[sorenlouv]

I'm thinking an initial solution could be to guard everything inside $locationChangeStart with a check so the redirect is only done for explicit plugins, eg Discover, Visualize, Management.

This way it won't affect plugins that uses other routing mechanism and url schemes.

[spalger]

7.0: 922eb1e
7.x/7.1: 89f45f2