Kibana route handler is duplicating hash + query params in some scenarios

[jasonrhodes]

Kibana version:
master at least, for now

Elasticsearch version:
8.0

Server OS version:

Browser version:
Chrome, Version 72.0.3626.121 (Official Build) (64-bit)

Browser OS version:
Mac OS X 10.14.3

Original install method (e.g. download page, yum, from source, etc.):
from source

Describe the bug:
Adding a query param with a value that typically requires URL encoding (e.g. "/") will cause the URL to update twice, once for the initial change, and then again with the entire hash + all query params URL encoded.

Example:
https://myserver.com/app/apm/#services?a=b/c

becomes

https://myserver.com/app/apm#/services?a=b%2Fc#%2Fservices%3Fa=b%252Fc

This appears to happen throughout Kibana. Confirmed in:

• discover
• visualize
• dashboard
• canvas
• maps
• machine learning
• infrastructure
• logs
• apm
• uptime
• graph
• dev tools
• stack monitoring
• management

Steps to reproduce:

1. Go to any URL in Kibana
2. Manually add a query param to whatever URL appears, like &a=b/c, press "enter"
3. Watch as the URL is updated to include an encoded copy of everything after the '#' in the original URL

Note: it will continue to copy everything repeatedly as you update the URL, copying the last copy in a recursive way.

Expected behavior:
The URL should only update once and not duplicate the hash + search string in an encoded copy at the end of the URL.

[jasonrhodes]

Could possibly be related to #32372

[spalger]

@jasonrhodes @sqren would you mind trying out #32732?

[jasonrhodes]

@spalger yep those changes seem to fix