-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving way to check if pipelines list is loaded #32370
Merged
dmlemeshko
merged 3 commits into
elastic:master
from
dmlemeshko:fix/improve-assertExists-in-pipeline-tests
Mar 4, 2019
Merged
Improving way to check if pipelines list is loaded #32370
dmlemeshko
merged 3 commits into
elastic:master
from
dmlemeshko:fix/improve-assertExists-in-pipeline-tests
Mar 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
💚 Build Succeeded |
retest |
💚 Build SucceededNow we have a proper waiting in place 💪
|
retest |
💚 Build Succeeded |
retest |
💚 Build Succeeded |
retest |
This reverts commit 1fb4077.
💚 Build Succeeded |
100 (5 builds * 20 ) runs passed, I think it's good enough. |
💚 Build Succeeded |
cuff-links
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran 10x. Works and LGTM.
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Mar 10, 2019
* [services/pipeline_list] wait for loadingPipelines is not displayed * run x-pack-ciGroup2 x20 times * Revert "run x-pack-ciGroup2 x20 times" This reverts commit 1fb4077.
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Mar 10, 2019
* [services/pipeline_list] wait for loadingPipelines is not displayed * run x-pack-ciGroup2 x20 times * Revert "run x-pack-ciGroup2 x20 times" This reverts commit 1fb4077.
dmlemeshko
added a commit
that referenced
this pull request
Mar 10, 2019
dmlemeshko
added a commit
that referenced
this pull request
Mar 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #32385 fixes
Sometimes pipelines table is present without content and it causes test to fail. Adding check that
loadingPipelines
div is not present before we try to get table content.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately