Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving way to check if pipelines list is loaded #32370

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Mar 2, 2019

Summary

Part of #32385 fixes
Sometimes pipelines table is present without content and it causes test to fail. Adding check that loadingPipelines div is not present before we try to get table content.

jobs elastic kibana pull-request job x-pack-cigrou

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 3, 2019

💚 Build Succeeded

Now we have a proper waiting in place 💪

[00:02:15]                 │ debg Waiting up to 20000ms for pipline list visible on screen...
[00:02:15]                 │ debg TestSubjects.find(pipelineList)
[00:02:15]                 │ debg Find.findByCssSelector('[data-test-subj~="pipelineList"]') with timeout=10000
[00:02:15]                 │ debg TestSubjects.exists(loadingPipelines)
[00:02:15]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="loadingPipelines"]') with timeout=2500
[00:02:17]                 │ debg Waiting up to 20000ms for pipline list visible on screen...
[00:02:17]                 │ debg TestSubjects.find(pipelineList)
[00:02:17]                 │ debg Find.findByCssSelector('[data-test-subj~="pipelineList"]') with timeout=10000
[00:02:17]                 │ debg TestSubjects.exists(loadingPipelines)
[00:02:17]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="loadingPipelines"]') with timeout=2500

@dmlemeshko
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko
Copy link
Member Author

retest

@dmlemeshko dmlemeshko added review and removed WIP Work in progress labels Mar 3, 2019
@dmlemeshko dmlemeshko requested a review from spalger March 3, 2019 12:06
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko
Copy link
Member Author

dmlemeshko commented Mar 3, 2019

100 (5 builds * 20 ) runs passed, I think it's good enough.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko dmlemeshko requested a review from cuff-links March 4, 2019 15:33
Copy link
Contributor

@cuff-links cuff-links left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 10x. Works and LGTM.

@dmlemeshko dmlemeshko merged commit 325df74 into elastic:master Mar 4, 2019
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Mar 10, 2019
* [services/pipeline_list] wait for loadingPipelines is not displayed

* run x-pack-ciGroup2 x20 times

* Revert "run x-pack-ciGroup2 x20 times"

This reverts commit 1fb4077.
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Mar 10, 2019
* [services/pipeline_list] wait for loadingPipelines is not displayed

* run x-pack-ciGroup2 x20 times

* Revert "run x-pack-ciGroup2 x20 times"

This reverts commit 1fb4077.
dmlemeshko added a commit that referenced this pull request Mar 10, 2019
* [services/pipeline_list] wait for loadingPipelines is not displayed

* run x-pack-ciGroup2 x20 times

* Revert "run x-pack-ciGroup2 x20 times"

This reverts commit 1fb4077.
dmlemeshko added a commit that referenced this pull request Mar 10, 2019
* [services/pipeline_list] wait for loadingPipelines is not displayed

* run x-pack-ciGroup2 x20 times

* Revert "run x-pack-ciGroup2 x20 times"

This reverts commit 1fb4077.
@dmlemeshko
Copy link
Member Author

Backported
7.0 737b544
7.x 43344f1

@dmlemeshko dmlemeshko deleted the fix/improve-assertExists-in-pipeline-tests branch April 22, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants