Improving way to check if pipelines list is loaded (elastic#32370)

* [services/pipeline_list] wait for loadingPipelines is not displayed * run x-pack-ciGroup2 x20 times * Revert "run x-pack-ciGroup2 x20 times" This reverts commit 1fb4077.
dmlemeshko · Mar 10, 2019 · 5c445d1 · 5c445d1
1 parent 1e416ca
commit 5c445d1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/x-pack/plugins/logstash/public/components/pipeline_list/pipeline_list.js b/x-pack/plugins/logstash/public/components/pipeline_list/pipeline_list.js
@@ -95,7 +95,7 @@ class PipelineListUi extends React.Component {
 
     this.setState({
       message: (
-        <div>
+        <div data-test-subj="loadingPipelines">
           <EuiLoadingSpinner size="m" />
           &nbsp; <FormattedMessage
             id="xpack.logstash.pipelineList.pipelinesLoadingMessage"

diff --git a/x-pack/test/functional/services/pipeline_list.js b/x-pack/test/functional/services/pipeline_list.js
@@ -163,7 +163,8 @@ export function PipelineListProvider({ getService }) {
       await retry.waitFor('pipline list visible on screen', async () => {
         const container = await testSubjects.find(SUBJ_CONTAINER);
         const found = await container.findAllByCssSelector('table tbody');
-        return found.length > 0;
+        const isLoading = await testSubjects.exists('loadingPipelines');
+        return (found.length > 0) && (isLoading === false);
       });
     }