Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Context Tabs jumping height fix #32351

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Mar 1, 2019

[APM] fixes #18144 by setting the container min-height to the tab with the largest rendered height

jumping-context-tabs-fix-min-height

@ogupte ogupte self-assigned this Mar 1, 2019
@ogupte ogupte requested a review from a team as a code owner March 1, 2019 22:55
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change. This has been annoying me for so long!! 🎉

/>
);
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this component to its own file?

@formgeist
Copy link
Contributor

@ogupte Great stuff! So looking forward to finally fixing this nuisance.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ogupte ogupte merged commit c7f5584 into elastic:master Mar 4, 2019
ogupte added a commit to ogupte/kibana that referenced this pull request Mar 4, 2019
* [APM] fixes elastic#18144 by setting the container min-height to the tab with the largest rendered height

* [APM] moved HeightRetainer into its own shared component module
ogupte added a commit that referenced this pull request Mar 4, 2019
* [APM] fixes #18144 by setting the container min-height to the tab with the largest rendered height

* [APM] moved HeightRetainer into its own shared component module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Keep context tabs from jumping
4 participants