Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Keep context tabs from jumping #18144

Closed
elasticmachine opened this issue Feb 14, 2018 · 1 comment · Fixed by #32351
Closed

[APM] Keep context tabs from jumping #18144

elasticmachine opened this issue Feb 14, 2018 · 1 comment · Fixed by #32351
Assignees
@ogupte
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support

Comments

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 14, 2018 •
edited by formgeist
Loading

Original comment by @makwarth:

Problem
The context tabs jumps down when switching from the (typically tall) waterfall tab to one of the other tabs. (See gif below)

Solution
Make the context tabs min-height the height of the active transaction sample waterfall tab

kapture 2018-02-14 at 13 22 29
@elasticmachine
Copy link
Contributor Author

Original comment by @makwarth:

@vanjacosic up for doing a POC for this? If it works, we can clean it up and ship with 6.3

@elasticmachine elasticmachine added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:APM All issues that need APM UI Team support labels Apr 24, 2018
@formgeist formgeist removed the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Sep 4, 2018
@alvarolobato alvarolobato added the bug Fixes for quality problems that affect the customer experience label Nov 9, 2018
@ogupte ogupte self-assigned this Mar 1, 2019
ogupte added a commit to ogupte/kibana that referenced this issue Mar 1, 2019
@ogupte
[APM] fixes elastic#18144 by setting the container min-height to the …
dd02b80 
…tab with the largest rendered height
@ogupte ogupte mentioned this issue Mar 1, 2019
Merged
ogupte added a commit to ogupte/kibana that referenced this issue Mar 4, 2019
@ogupte
[APM] Context Tabs jumping height fix (elastic#32351)
0ee3087 
* [APM] fixes elastic#18144 by setting the container min-height to the tab with the largest rendered height

* [APM] moved HeightRetainer into its own shared component module
ogupte added a commit that referenced this issue Mar 4, 2019
@ogupte
[APM] Context Tabs jumping height fix (#32351)
c7f5584 
* [APM] fixes #18144 by setting the container min-height to the tab with the largest rendered height

* [APM] moved HeightRetainer into its own shared component module
ogupte added a commit that referenced this issue Mar 4, 2019
@ogupte
[APM] Context Tabs jumping height fix (#32351) (#32410)
aa008e7 
* [APM] fixes #18144 by setting the container min-height to the tab with the largest rendered height

* [APM] moved HeightRetainer into its own shared component module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Context Tabs jumping height fix ogupte/kibana
5 participants
@ogupte @formgeist @elasticmachine @alvarolobato @BernardIsibor