Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InfraUI] Add Infrastructure and Logs Help Menu content #32118

Merged

Conversation

Kerry350
Copy link
Contributor

@Kerry350 Kerry350 commented Feb 27, 2019

Summary

Addresses: #29687

Overview:

Uses the Kibana Help Menu item to add relevant content (Feedback links) for Infrastructure and Logs, uses the same wording as APM.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

Remove old Feedback link component (removed with K7)

Add a HelpCenterContent component

Add HelpCenterContent to Infrastructure

Add HelpCenterContent to Logs
@Kerry350 Kerry350 added review Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Feb 27, 2019
@Kerry350 Kerry350 self-assigned this Feb 27, 2019
@Kerry350 Kerry350 requested review from simianhacker and skh February 27, 2019 13:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/infrastructure-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@skh skh removed the request for review from simianhacker March 4, 2019 13:46
Copy link
Contributor

@skh skh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as described 👍

@Kerry350 Kerry350 merged commit ce79bb1 into elastic:master Mar 4, 2019
Kerry350 added a commit to Kerry350/kibana that referenced this pull request Mar 5, 2019
Remove old Feedback link component (removed with K7)

Add a HelpCenterContent component

Add HelpCenterContent to Infrastructure

Add HelpCenterContent to Logs
Kerry350 added a commit that referenced this pull request Mar 5, 2019
Remove old Feedback link component (removed with K7)

Add a HelpCenterContent component

Add HelpCenterContent to Infrastructure

Add HelpCenterContent to Logs
@timroes timroes added the v7.2.0 label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature review Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants