-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InfraUI] Add Infrastructure and Logs Help Menu content #32118
Merged
Kerry350
merged 2 commits into
elastic:master
from
Kerry350:29687-add-links-to-kibana-help-menu
Mar 4, 2019
Merged
[InfraUI] Add Infrastructure and Logs Help Menu content #32118
Kerry350
merged 2 commits into
elastic:master
from
Kerry350:29687-add-links-to-kibana-help-menu
Mar 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old Feedback link component (removed with K7) Add a HelpCenterContent component Add HelpCenterContent to Infrastructure Add HelpCenterContent to Logs
Kerry350
added
review
Feature:Metrics UI
Metrics UI feature
v8.0.0
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
labels
Feb 27, 2019
Pinging @elastic/infrastructure-ui |
💚 Build Succeeded |
💚 Build Succeeded |
skh
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, works as described 👍
2 tasks
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Mar 5, 2019
Remove old Feedback link component (removed with K7) Add a HelpCenterContent component Add HelpCenterContent to Infrastructure Add HelpCenterContent to Logs
Kerry350
added a commit
that referenced
this pull request
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Metrics UI
Metrics UI feature
review
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v7.2.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: #29687
Overview:
Uses the Kibana Help Menu item to add relevant content (Feedback links) for Infrastructure and Logs, uses the same wording as APM.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios