[APM] Move APM feedback link to global Help popover #30918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest |
💔 Build Failed |
💔 Build Failed |
sorenlouv
approved these changes
Feb 18, 2019
sorenlouv
reviewed
Feb 18, 2019
| @@ -28,6 +30,25 @@ import { history } from './components/shared/Links/url_helpers'; | |||
|
|
|||
| import { I18nContext } from 'ui/i18n'; | |||
|
|
|||
| // render APM feedback link in global help menu | |||
| chrome.helpExtension.set(domElement => { | |||
There was a problem hiding this comment.
Is this the only API for setting the help menu? I was expecting it to be more strictly defined - and if anything that it would assume React. I guess it's a good thing that it's framework agnostic - just not how I expected it to be...
2 tasks
formgeist
requested changes
Feb 19, 2019
x-pack/plugins/apm/public/index.js
Outdated
| rel="noopener" | ||
| > | ||
| {i18n.translate('xpack.apm.feedbackMenu.provideFeedbackTitle', { | ||
| defaultMessage: 'Give APM Feedback' |
There was a problem hiding this comment.
Can we change this to "Provide feedback for APM"?
x-pack/plugins/apm/public/index.js
Outdated
| defaultMessage: 'Give APM Feedback' | ||
| })} | ||
| </EuiLink>, | ||
| domElement |
There was a problem hiding this comment.
Can we add another link to the Kibana Migration Assistant? Link is /app/kibana#/management/elasticsearch/upgrade_assistant and happens within Kibana so no target and no rel props necessary, afaik?
formgeist
approved these changes
Feb 20, 2019
|
@ogupte Looks good to me, thanks 👍 |
💔 Build Failed |
💔 Build Failed |
|
retest |
💔 Build Failed |
|
retest |
💔 Build Failed |
… the datepicker section and adding the link as custom content in the global help popover.
ogupte
force-pushed
the
apm-29687-feedback-link-global-help
branch
from
fbaa427 to
ba43742
Compare
💚 Build Succeeded |
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Feb 20, 2019
* [APM] Closes elastic#29687 by removing the old APM feedback link from the datepicker section and adding the link as custom content in the global help popover. * remove noreferrer property for the feedback link * [APM] updated feedback link text and added help link to migration assistant * [APM] remove unused translations related to the old feedback link
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Feb 20, 2019
* [APM] Closes elastic#29687 by removing the old APM feedback link from the datepicker section and adding the link as custom content in the global help popover. * remove noreferrer property for the feedback link * [APM] updated feedback link text and added help link to migration assistant * [APM] remove unused translations related to the old feedback link
ogupte
added a commit
that referenced
this pull request
Feb 20, 2019
* [APM] Closes #29687 by removing the old APM feedback link from the datepicker section and adding the link as custom content in the global help popover. * remove noreferrer property for the feedback link * [APM] updated feedback link text and added help link to migration assistant * [APM] remove unused translations related to the old feedback link
ogupte
added a commit
that referenced
this pull request
Feb 20, 2019
* [APM] Closes #29687 by removing the old APM feedback link from the datepicker section and adding the link as custom content in the global help popover. * remove noreferrer property for the feedback link * [APM] updated feedback link text and added help link to migration assistant * [APM] remove unused translations related to the old feedback link
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29687 by removing the old APM feedback link from the datepicker section and adding the link as custom content in the global help popover.