Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSVB: Option to open links in new tab #31906

Merged
merged 1 commit into from
Feb 26, 2019
Merged

TSVB: Option to open links in new tab #31906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/legacy/core_plugins/metrics/public/components/panel_config/markdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,22 @@ class MarkdownPanelConfigUi extends Component {
onChange={this.props.onChange}
/>
</EuiFlexItem>

<EuiFlexItem grow={false}>
<EuiFormLabel style={{ marginBottom: 0 }}>
<FormattedMessage
id="tsvb.markdown.optionsTab.openLinksInNewTab"
defaultMessage="Open links in new tab?"
/>
</EuiFormLabel>
</EuiFlexItem>
<EuiFlexItem>
<YesNo
value={model.markdown_openLinksInNewTab}
name="markdown_openLinksInNewTab"
onChange={this.props.onChange}
/>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiFormLabel style={{ marginBottom: 0 }} htmlFor={htmlId('valign')}>
<FormattedMessage
Expand Down
4 changes: 3 additions & 1 deletion src/legacy/core_plugins/metrics/public/components/vis_types/markdown/vis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ function MarkdownVisualization(props) {
{markdownError && <ErrorComponent error={markdownError} />}
<style type="text/css">{markdownCss}</style>
<div className={contentClasses}>
<div id={markdownElementId}>{!markdownError && <Markdown markdown={markdownSource} />}</div>
<div id={markdownElementId}>
{ !markdownError && <Markdown markdown={markdownSource} openLinksInNewTab={model.markdown_openLinksInNewTab} /> }
</div>
</div>
</div>
);
Expand Down