Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVB: Option to open links in new tab #31906

Merged
merged 1 commit into from
Feb 26, 2019
Merged

TSVB: Option to open links in new tab #31906

merged 1 commit into from
Feb 26, 2019

Conversation

alexwizp
Copy link
Contributor

Summary

Fix: #21992

link_1

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

sulemanof
sulemanof approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp
Copy link
Contributor Author

@AlonaNadler Are you ok with that UI changes?

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@AlonaNadler
Copy link

Yes looks great :)

markov00
markov00 approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works correctly. Code LGTM

@alexwizp alexwizp merged commit 9f4426b into elastic:master Feb 26, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 26, 2019
@alexwizp
TSVB: Option to open links in new tab (elastic#31906)
75ae1ba
@alexwizp alexwizp mentioned this pull request Feb 26, 2019
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 26, 2019
@alexwizp
TSVB: Option to open links in new tab (elastic#31906)
24dce9e
@alexwizp alexwizp mentioned this pull request Feb 26, 2019
Merged
alexwizp added a commit that referenced this pull request Feb 26, 2019
@alexwizp
TSVB: Option to open links in new tab (#31906) (#32007)
39bad6d
alexwizp added a commit that referenced this pull request Feb 26, 2019
@alexwizp
TSVB: Option to open links in new tab (#31906) (#32006)
7f7f48b
@alexwizp alexwizp deleted the 21992 branch January 4, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulemanof sulemanof sulemanof approved these changes

@markov00 markov00 markov00 approved these changes

@timroes timroes Awaiting requested review from timroes

@flash1293 flash1293 Awaiting requested review from flash1293

Assignees
No one assigned
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexwizp @elasticmachine @AlonaNadler @markov00 @sulemanof