Introduce workaround for vega height bug #31461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
flash1293
force-pushed
the
25855/fix-vega-height-bug
branch
from
cdfcf71 to
daf4590
Compare
💚 Build Succeeded |
flash1293
changed the title
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
nyurik
approved these changes
Feb 19, 2019
flash1293
force-pushed
the
25855/fix-vega-height-bug
branch
from
b6bad88 to
94efec0
Compare
|
@nyurik Done! It seems like this bug is triggered by very specific circumstances. For instance it didn't trigger if the font-size in the sample spec is smaller than 14px (maybe has sth. to do with the total height? No idea...) |
💚 Build Succeeded |
timroes
approved these changes
Feb 21, 2019
@timroes anything specific that Vega team can act on? They have been making amazing progress in code quality improvements - merged it into a monorepo, began using async/await, etc. It would be great if we can help them in this "never ending quest for quality and performance" :) |
|
Waiting for #31693 before merging this |
|
Tested the backported fix on 7.0, works also in IE |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 25, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 25, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 25, 2019
flash1293
added a commit
that referenced
this pull request
Feb 26, 2019
flash1293
added a commit
that referenced
this pull request
Feb 26, 2019
flash1293
added a commit
that referenced
this pull request
Feb 26, 2019
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jul 22, 2020
7 tasks
alexwizp
added a commit
that referenced
this pull request
Jul 23, 2020
* Failing test: Jest Tests.src/plugins/vis_type_vega/public * remove workaround for vega height bug Related to #31461 Co-authored-by: Elastic Machine <[email protected]>
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jul 23, 2020
) * Failing test: Jest Tests.src/plugins/vis_type_vega/public * remove workaround for vega height bug Related to elastic#31461 Co-authored-by: Elastic Machine <[email protected]>
alexwizp
added a commit
that referenced
this pull request
Jul 23, 2020
…73015) * Failing test: Jest Tests.src/plugins/vis_type_vega/public * remove workaround for vega height bug Related to #31461 Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25855
This is a workaround which hopefully becomes obsolete with vega 5 (currently upgrading doesn't work because of #31413
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately