Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana doesn't load in IE #31693

Closed
flash1293 opened this issue Feb 21, 2019 · 8 comments
Closed

Kibana doesn't load in IE #31693

flash1293 opened this issue Feb 21, 2019 · 8 comments
Labels
bug Fixes for quality problems that affect the customer experience Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@flash1293
Copy link
Contributor

Current Kibana master doesn't load in IE due to some react-intl related error
screenshot_2019-02-20_at_11 12 11

6.7, 7.0 and 7.x do work though.

@Bamieh

@flash1293 flash1293 added bug Fixes for quality problems that affect the customer experience Project:i18n labels Feb 21, 2019
@snide
Copy link
Contributor

snide commented Feb 21, 2019

cc @elastic/kibana-qa and @elastic/kibana-design so they are aware.

@chandlerprall
Copy link
Contributor

I reproduced in IE11 locally against master

packages/kbn-i18n/node_modules/react-intl/lib/index.js
Line 165, Column: 5

maps to the 2nd line of

  if (typeof Symbol === "function" && Symbol.asyncIterator) {
    AsyncGenerator.prototype[Symbol.asyncIterator] = function () {
      return this;
    };
  }

Running this in the IE11 console creates the same error:

thing = function() {};
thing.prototype[Symbol.asyncIterator]

@azasypkin azasypkin added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Feb 22, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@chandlerprall
Copy link
Contributor

chandlerprall commented Feb 22, 2019

bisecting commits through git, appears to be 3727b53 #29072 which introduces the change breaking IE11.

Moving before that commit there is an existing error in IE11 about a SyntaxError: Expected ';' from ./node_modules/vega-lib/build/vega.js in vendors.bundle.dll.js, so there may be a few issues to resolve for IE support.

@flash1293
Copy link
Contributor Author

flash1293 commented Feb 22, 2019

@chandlerprall The vega issue gets resolved with 562edd6
so that shouldn't pop up again if the problem with 3727b53 #29072 gets resolved (at least it works in the PR branch flash1293:fix/vega-version which was based on a commit prior to 3727b53). If this shouldn't be the case, please ping me.

For testing: Cherry-picking 562edd6 on top of the commit before 3727b53 should work if there isn't a third IE breaking change at the same time.

@chandlerprall
Copy link
Contributor

Specifically, adding "@storybook/react": "^4.0.7", to x-pack's package.json triggers the error. There is a release note on 4.1.6 that it includes an IE11 fix, bumping to that version removes the error but still no pageload happens (stays on a blank screen).

Adding the @storybook/react dependency duplicates or triplicates a number of babel-related packages in yarn.lock (all with miniscule version differences) so that's where I'm looking now. It might be best to remove the storybook dependencies for now to get master working again. @clintandrewhall

@flash1293
Copy link
Contributor Author

flash1293 commented Feb 24, 2019

I talked to @mistic about this while trying to fix the vega problem, and it might be possible to resolve this by configuring webpack to correctly compile this stuff down to IE supported syntax (packages/kbn-babel-preset). If we find a reliable way to prevent this, #31413 should get a lot easier.

For now it makes more sense to just revert though IMHO, no idea how easy it is to resolve this once and for all without unwanted side effects (like killing compile performance)

@cchaos
Copy link
Contributor

cchaos commented Mar 4, 2019

🎉 @chandlerprall !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

6 participants