Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datepicker in ie11 #31216

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Fix datepicker in ie11 #31216

merged 3 commits into from
Feb 21, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Feb 14, 2019

Summary

Fixes #31211

Flex issues around the datepicker in ie11. Will require backports to 7.

image

Checklist

  • This was checked for cross-browser compatibility, [including a check against IE11

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cchaos cchaos self-requested a review February 15, 2019 03:53
@LeeDr
Copy link

LeeDr commented Feb 15, 2019

When I try to test this locally, Kibana opens in Chrome just fine but in IE11 I get this (not sure if it's a Vega problem? I guess I need to try a clean master on IE11);


Expected ';'


Version: 8.0.0
Build: 9007199254740991
SyntaxError: Expected ';'
   at ./node_modules/vega-lib/build/vega.js (http://localhost:5620/built_assets/dlls/vendors.bundle.dll.js:34651:1)
   at __webpack_require__ (http://localhost:5620/built_assets/dlls/vendors.bundle.dll.js:21:12)
   at ./node_modules/vega-lib/build/vega.js (http://localhost:5620/bundles/kibana.bundle.js:1226:1)
   at __webpack_require__ (http://localhost:5620/bundles/kibana.bundle.js:79:12)
   at ./src/legacy/core_plugins/vega/public/data_model/vega_parser.js (http://localhost:5620/bundles/kibana.bundle.js:90049:1)
   at __webpack_require__ (http://localhost:5620/bundles/kibana.bundle.js:79:12)
   at ./src/legacy/core_plugins/vega/public/vega_request_handler.js (http://localhost:5620/bundles/kibana.bundle.js:90951:1)
   at __webpack_require__ (http://localhost:5620/bundles/kibana.bundle.js:79:12)
   at ./src/legacy/core_plugins/vega/public/vega_type.js (http://localhost:5620/bundles/kibana.bundle.js:91025:1)
   at __webpack_require__ (http://localhost:5620/bundles/kibana.bundle.js:79:12)


Unable to get property 'scrollTop' of undefined or null reference (:175)


Version: 8.0.0
Build: 9007199254740991

@cchaos
Copy link
Contributor

cchaos commented Feb 15, 2019

We'll need to add this as a flex-grow: 0 for larger media queries though, because it ends up like this on small screens

image

vs what it supposed to do:

image

@LeeDr
Copy link

LeeDr commented Feb 15, 2019

The problem I had in testing the PR was caused by this recent change;
#30628

@flash1293 is working on a fix for that

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@flash1293
Copy link
Contributor

@snide Fix for the IE testing problem landed in master

@flash1293
Copy link
Contributor

@LeeDr There might be another bug preventing this from getting tested in IE - #31288

@snide snide requested a review from a team as a code owner February 21, 2019 20:04
@snide
Copy link
Contributor Author

snide commented Feb 21, 2019

@cchaos I now apply it through the breakpoint you had set up. For mobile it expands as normal.

image

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't check IE, but works in chrome and FF

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Feb 21, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@snide snide merged commit f6770b1 into elastic:master Feb 21, 2019
@snide snide deleted the ie/dp branch February 21, 2019 22:13
snide added a commit to snide/kibana that referenced this pull request Feb 21, 2019
Fixes the datepicker so it shows in ie
snide added a commit to snide/kibana that referenced this pull request Feb 21, 2019
Fixes the datepicker so it shows in ie
snide added a commit that referenced this pull request Feb 21, 2019
Fixes the datepicker so it shows in ie
snide added a commit that referenced this pull request Feb 23, 2019
Fixes the datepicker so it shows in ie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants