Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of geoip and user-agent processor from Add Data UI #30866

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Feb 12, 2019

In Elasticsearch 7.0 the geoip and the user_agent processor as shipped by default. This means the step to install geoip and the user_agent plugins need to be removed.

After removing Install geoip and user-agent plugins:
screen shot 2019-02-12 at 11 02 34 am

closes #30842

@kaiyan-sheng kaiyan-sheng self-assigned this Feb 12, 2019
@kaiyan-sheng kaiyan-sheng added Team:Beats Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Feb 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/beats

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kaiyan-sheng kaiyan-sheng requested a review from ruflin February 13, 2019 14:33
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably to a follow up PR against master to clean up the code that uses geoipRequired and uaRequired to not have it in Kibana anymore.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kaiyan-sheng
Copy link
Contributor Author

@ruflin sounds good. I will make a separate PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Beats Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mention of geoip and user-agent processor from Add Data UI
3 participants