Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n documentation [skip ci] #30818

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Fix i18n documentation [skip ci] #30818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-i18n/GUIDELINE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Messages can contain placeholders for embedding a value of a variable. For examp
}
```

Mostly such placeholders have meaningful name according to the сontent.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first letter was actually a Russian с (s) and not a latin c :-)

Mostly such placeholders have meaningful name according to the content.

### Pluralization

Expand Down
2 changes: 1 addition & 1 deletion packages/kbn-i18n/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export function getGreetingMessage(userName) {
return i18n.translate('hello.wonderful.world', {
defaultMessage: 'Greetings, {name}!',
values: { name: userName },
context: 'This is greeting message for main screen.'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that property has been renamed over time, and it's now called description.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, thank you for fixing it

description: 'This is greeting message for main screen.'
});
}
```
Expand Down