Fix i18n documentation [skip ci] #30818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Team:Core
|
Pinging @elastic/kibana-platform |
timroes
commented
Feb 12, 2019
| @@ -62,7 +62,7 @@ Messages can contain placeholders for embedding a value of a variable. For examp | |||
| } | |||
| ``` | |||
|
|
|||
| Mostly such placeholders have meaningful name according to the сontent. | |||
There was a problem hiding this comment.
The first letter was actually a Russian с (s) and not a latin c :-)
timroes
commented
Feb 12, 2019
| @@ -175,7 +175,7 @@ export function getGreetingMessage(userName) { | |||
| return i18n.translate('hello.wonderful.world', { | |||
| defaultMessage: 'Greetings, {name}!', | |||
| values: { name: userName }, | |||
| context: 'This is greeting message for main screen.' | |||
There was a problem hiding this comment.
I think that property has been renamed over time, and it's now called description.
There was a problem hiding this comment.
right, thank you for fixing it
maryia-lapata
approved these changes
Feb 12, 2019
| @@ -175,7 +175,7 @@ export function getGreetingMessage(userName) { | |||
| return i18n.translate('hello.wonderful.world', { | |||
| defaultMessage: 'Greetings, {name}!', | |||
| values: { name: userName }, | |||
| context: 'This is greeting message for main screen.' | |||
There was a problem hiding this comment.
right, thank you for fixing it
|
Doc only change, don't need to wait for CI (I actually forgot |
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Feb 12, 2019
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Feb 12, 2019
💔 Build Failed |
timroes
added a commit
that referenced
this pull request
Feb 12, 2019
timroes
added a commit
that referenced
this pull request
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the i18n framework documentation.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately